From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: gpio_keys - fall back to platform_get_irq() for interrupt-only keys
Date: Wed, 20 Aug 2025 16:37:25 +0300 [thread overview]
Message-ID: <aKXPlSXlujuPPuzl@smile.fi.intel.com> (raw)
In-Reply-To: <20250817224731.1911207-1-dmitry.torokhov@gmail.com>
On Sun, Aug 17, 2025 at 03:47:26PM -0700, Dmitry Torokhov wrote:
> To allow transitioning away from gpio-keys platform data attempt to
> retrieve IRQ for interrupt-only keys using platform_get_irq_optional()
> if interrupt is not specified in platform data.
...
> + irq = platform_get_irq_optional(pdev, idx);
> + if (irq < 0) {
> + error = irq;
> + return dev_err_probe(dev, error,
Assigning error is redundant.
> + "Unable to determine IRQ# for button #%d",
> + idx);
> + }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-08-20 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 22:47 [PATCH 1/3] Input: gpio_keys - fall back to platform_get_irq() for interrupt-only keys Dmitry Torokhov
2025-08-17 22:47 ` [PATCH 2/3] mfd: rohm-bd71828: Use software nodes for gpio-keys Dmitry Torokhov
2025-08-18 6:54 ` Matti Vaittinen
2025-08-18 6:56 ` Matti Vaittinen
2025-08-18 17:11 ` Dmitry Torokhov
2025-08-19 10:49 ` Matti Vaittinen
2025-08-17 22:47 ` [PATCH 3/3] mfd: rohm-bd718x7: " Dmitry Torokhov
2025-08-18 6:57 ` Matti Vaittinen
2025-08-20 13:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXPlSXlujuPPuzl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.