From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Mika Westerberg <westeri@kernel.org>,
"open list:GPIO ACPI SUPPORT" <linux-gpio@vger.kernel.org>,
"open list:GPIO ACPI SUPPORT" <linux-acpi@vger.kernel.org>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: amd: Add PM debugging message for turning on/off wakes
Date: Wed, 20 Aug 2025 16:45:42 +0300 [thread overview]
Message-ID: <aKXRhvJK1NoETu_L@smile.fi.intel.com> (raw)
In-Reply-To: <20250814183430.3887973-2-superm1@kernel.org>
On Thu, Aug 14, 2025 at 01:34:30PM -0500, Mario Limonciello (AMD) wrote:
> The GPIOs for devices not in _AEI/_EVT such as touchpad or touchscreen
> won't have wakeup turned on until the suspend sequence starts.
>
> Due to code in amd_gpio_suspend_hibernate_common() masking the interrupt
> can make this difficult to follow what's going on. Add an explicit
> debugging message to tell when that was turned on/off.
...
> + pm_pr_dbg("Setting wake for GPIO %lu to %s\n",
> + d->hwirq, str_enable_disable(on));
Can you send a follow up to move from dereference to an API for hwirq?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-20 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 18:34 [PATCH 1/2] gpiolib: acpi: Add quirk for ASUS ProArt PX13 Mario Limonciello (AMD)
2025-08-14 18:34 ` [PATCH 2/2] pinctrl: amd: Add PM debugging message for turning on/off wakes Mario Limonciello (AMD)
2025-08-20 13:45 ` Andy Shevchenko [this message]
2025-08-15 6:45 ` [PATCH 1/2] gpiolib: acpi: Add quirk for ASUS ProArt PX13 Mika Westerberg
2025-08-19 12:16 ` Linus Walleij
2025-08-20 13:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXRhvJK1NoETu_L@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.