From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33B26142E83 for ; Wed, 20 Aug 2025 13:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755697938; cv=none; b=pyHXtAFTsHsoj4YrdPsA4vOoAEsu3kDG429s5Y5GVdwpjdqMRM185zFXGRdWusAmrTUG5MBxbwGx0zOpT0kqHxc5mYawKUW7mqf+98KDwkeWzf2bFK6jJpSmS7HgwRCo0b+sF/ryR2Hf3wM96s0IUae+tOuT2SA10/tMLcfczKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755697938; c=relaxed/simple; bh=x9m6lyZr89uhKMYacvX3Uxb5ULz79Sabw7pdWj/rTVs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rPuorMzcyRP3CNYNWxCAJ7CQsm0Q+sUcHTS6U9jOsHMC08u+OaQo5YiUgqTIARkjP3HCEV20HH8d0MhrFlAmZ7wnsoW7X8SJkx1nrl4GGrL/7J2+uu1TdUkgPYo4wOGOcmI4yyvA328UJEvBigE1iCPRbIz6oZrfeU3gXwBL2Jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 650381D31; Wed, 20 Aug 2025 06:52:07 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7780D3F63F; Wed, 20 Aug 2025 06:52:13 -0700 (PDT) Date: Wed, 20 Aug 2025 14:52:10 +0100 From: Cristian Marussi To: Peng Fan Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Arnd Bergmann , Sudeep Holla , Cristian Marussi , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] firmware: imx: Add stub functions for SCMI LMM API Message-ID: References: <20250807-imx9-sm-v1-0-3489e41a6fda@nxp.com> <20250807-imx9-sm-v1-2-3489e41a6fda@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807-imx9-sm-v1-2-3489e41a6fda@nxp.com> On Thu, Aug 07, 2025 at 09:47:43AM +0800, Peng Fan wrote: > To ensure successful builds when CONFIG_IMX_SCMI_LMM_DRV is not enabled, > this patch adds static inline stub implementations for the following > functions: > > - scmi_imx_lmm_operation() > - scmi_imx_lmm_info() > - scmi_imx_lmm_reset_vector_set() > > These stubs return -EOPNOTSUPP to indicate that the functionality is not > supported in the current configuration. This avoids potential build or > link errors in code that conditionally calls these functions based on > feature availability. > > Fixes: 7242bbf418f0 ("firmware: imx: Add i.MX95 SCMI LMM driver") > Signed-off-by: Peng Fan > --- > include/linux/firmware/imx/sm.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/firmware/imx/sm.h b/include/linux/firmware/imx/sm.h > index 99c15bbb46aa8329b5aa8e03017e152074cdf492..f2a72177bb37c1d46145a60710e3809641e0f5a2 100644 > --- a/include/linux/firmware/imx/sm.h > +++ b/include/linux/firmware/imx/sm.h > @@ -56,7 +56,24 @@ enum scmi_imx_lmm_op { > #define SCMI_IMX_LMM_OP_FORCEFUL 0 > #define SCMI_IMX_LMM_OP_GRACEFUL BIT(0) > > +#if IS_ENABLED(CONFIG_IMX_SCMI_LMM_DRV) > int scmi_imx_lmm_operation(u32 lmid, enum scmi_imx_lmm_op op, u32 flags); > int scmi_imx_lmm_info(u32 lmid, struct scmi_imx_lmm_info *info); > int scmi_imx_lmm_reset_vector_set(u32 lmid, u32 cpuid, u32 flags, u64 vector); > +#else > +static inline int scmi_imx_lmm_operation(u32 lmid, enum scmi_imx_lmm_op op, u32 flags) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline int scmi_imx_lmm_info(u32 lmid, struct scmi_imx_lmm_info *info) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline int scmi_imx_lmm_reset_vector_set(u32 lmid, u32 cpuid, u32 flags, u64 vector) > +{ > + return -EOPNOTSUPP; > +} > +#endif > #endif LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian