Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Tue, Aug 19, 2025 at 11:47:58AM +0200, Neil Armstrong wrote:
> Hi,
> 
> On 14/08/2025 18:30, Venkat Jayaraman wrote:
> > Add support for UCSI READ_POWER_LEVEL command as per
> > UCSI specification v2.1 and above to debugfs.
> > 
> > Following power related fields will be exposed as files in debugfs:-
> > peak_current (Peak current),
> > avg_current (Average current) and
> > vbus_voltage (VBUS voltage)
> > 
> > These files will be updated either when a READ_POWER_LEVEL
> > command is sent from OS or when a device is connected.
> > 
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> > ---
> > Changelog v3:
> > - Rebased to kernel 6.17-rc1
> > 
> > Changelog v2:
> > - Removed extra space in declaration
> > - Made the call to debugfs_create_file single line for clarity
> > 
> >   drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
> >   drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
> >   drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
> >   3 files changed, 60 insertions(+)
> > 
> 
> This commit causes the following warning:
> [    8.646179] ------------[ cut here ]------------
> [    8.650986] Access to unsupported field at offset 0x59 (need version 0210)
> [    8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0: kworker/0:0/9
> <snip>
> [    8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
> [    8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
> [    8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
> [    8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> [    8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
> <snip>
> [    8.944023] Call trace:
> [    8.946570]  ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
> [    8.953328]  process_one_work+0x148/0x28c
> [    8.957502]  worker_thread+0x2c8/0x3d0
> [    8.961401]  kthread+0x12c/0x204
> [    8.964759]  ret_from_fork+0x10/0x20
> [    8.968474] ---[ end trace 0000000000000000 ]---
> 
> on:
> 8550-hdk:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
> 8550-qrd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
> 8650-hdk:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
> 8650-qrd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
> x1-crd:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
> x1-qcp:
> https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160
> 
> I guess the version should be checked.

Venkat, can you be prepare the fix for this?

thanks,

-- 
heikki