From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andreas Klinger <ak@it-klinger.de>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lars@metafoo.de,
javier.carrasco.cruz@gmail.com, mazziesaccount@gmail.com,
arthur.becker@sentec.com, perdaniel.olsson@axis.com,
mgonellabolduc@dimonoff.com, muditsharma.info@gmail.com,
clamor95@gmail.com, emil.gedenryd@axis.com,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] iio: light: add support for veml6046x00 RGBIR color sensor
Date: Thu, 21 Aug 2025 12:43:10 +0300 [thread overview]
Message-ID: <aKbqLpJMCxJd3QXW@smile.fi.intel.com> (raw)
In-Reply-To: <aIMy_BHJYNA20k-x@mail.your-server.de>
On Fri, Jul 25, 2025 at 09:32:12AM +0200, Andreas Klinger wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> schrieb am Mi, 16. Jul 10:34:
...
> > > +#define VEML6046X00_GAIN_1 0x0
> > > +#define VEML6046X00_GAIN_2 0x1
> > > +#define VEML6046X00_GAIN_0_66 0x2
> > > +#define VEML6046X00_GAIN_0_5 0x3
> >
> > Is it defined as hexadecimal in the datasheet? Otherwise use plain decimal
> > numbers.
>
> It's in the datasheet defined exactly the way i did.
OK!
...
> > > + part_id = le16_to_cpu(reg);
> > > + if (part_id != 0x0001)
> > > + dev_info(dev, "Unknown ID %#04x\n", part_id);
> >
> > For 0 it will print 0 and not 0x0000. Is it okay?
>
> I just tried and it prints 0x00 if the part_id is 0.
This is interesting... So it's not 0, nor 0x0000?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-21 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 8:58 [PATCH v6 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor Andreas Klinger
2025-07-15 8:58 ` [PATCH v6 1/3] dt-bindings: iio: light: veml6046x00: add " Andreas Klinger
2025-07-15 8:58 ` [PATCH v6 2/3] iio: light: add support for veml6046x00 RGBIR " Andreas Klinger
2025-07-16 7:34 ` Andy Shevchenko
2025-07-25 7:32 ` Andreas Klinger
2025-08-21 9:43 ` Andy Shevchenko [this message]
2025-08-21 18:53 ` Andreas Klinger
2025-08-22 5:39 ` Matti Vaittinen
2025-08-22 7:23 ` Andy Shevchenko
2025-08-22 7:59 ` Andy Shevchenko
2025-07-19 17:13 ` Jonathan Cameron
2025-07-15 8:58 ` [PATCH v6 3/3] MAINTAINER: add maintainer for veml6046x00 Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKbqLpJMCxJd3QXW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=arthur.becker@sentec.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.gedenryd@axis.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mgonellabolduc@dimonoff.com \
--cc=muditsharma.info@gmail.com \
--cc=perdaniel.olsson@axis.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.