Re: [PATCH v2] ARM64: dts: mcbin: fix SATA ports on Macchiatobin

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Aug 21, 2025 at 08:25:21PM +0200, Andrew Lunn wrote:
> > Hi,
> > 
> > I sent it at least twice..maybe this new was added in between.
> > But i have no marvell board for testing so i cannot verify my changes are correct.
> > I only tried to fix binding errors.
> > regards Frank
> 
> You might be able to use ./scripts/dtc/dtx_diff
> 
> Generate the DTB before the change and after, and they should be
> identical if the disable in the dtsi is correctly re-enabled in the
> .dts file.

I'm not sure that would help, because before Frank's patch, there were
no "status" properties in any of the sata-port nodes. After Frank's
patch, we end up with a mixture of "okay" and "disabled" depending
on whether the port is actually used - and the problem here is catching
all those that are actually being used on the hardware. In other words,
those notes that should have status = "okay" rather than status =
"disabled" added to them.

As I just stated, using grep:

$ grep -rA4 sata-port@ arch/arm64/boot/dts/marvell

is sufficient to find all the locations in the dts(i) files that have
a sata-port node defined, and in the context gives the rest of the
node properties, thus showing whether there is a status property present
or missing.

This is _exactly_ how I've identified that there are two more platforms
that are similarly broken.

This is not something that one can trivially check by doing a boot test
on platforms - I missed it despite booting the kernel on another
Macchiatobin as it's only a single kernel message amongst many that
says that something's wrong.

The only real way of doing this kind of change is to use grep and
similar to check that all sites have been caught.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!