Re: test/common: stop relying on bash $SECONDS in check_dmesg()

[Alison Schofield <alison.schofield@intel.com>]

Marc - There is something off with the patchset format.
The cover letter is usually Patch 0, so this would look like
like:

[ndctl PATCH 0/3] test/common: stop relying on bash $SECONDS in check_dmesg()
[ndctl PATCH 1/3] test/common: add missing quotes
[ndctl PATCH 2/3] test/common: move err() function at the top
[ndctl PATCH 3/3] test/common: stop relying on bash $SECONDS in check_dmesg()

The cover letter commit message should be general, not same as one of
it's child patches. This ship has sailed, but for next time take a
closer look at what your patch sending tool is generating.


On Thu, Jul 24, 2025 at 10:00:43PM +0000, marc.herbert@linux.intel.com wrote:
> As requested, this is the broken-down, first part of
>   https://lore.kernel.org/linux-cxl/20250611235256.3866724-1-marc.herbert@linux.intel.com/
>   test: fail on unexpected kernel error & warning, not just "Call Trace"
> 
> I will resubmit the rest after the review of this first part is
> completed. The different parts are logically separate (different
> "features") but they are interleaved in the same function and I don't
> really have the time to fix one git conflict per review comment. 
> 
> While it is a requirement to catch warnings and errors later, the
> better accuracy provided by this first part is useful alone. If you
> are interested in what's next, just look at the bigger patch above.
> You don't have to!
>