Re: [PATCH 2/3] io_uring/cmd: deduplicate uring_cmd_flags checks

[Ming Lei <ming.lei@redhat.com>]

On Thu, Aug 21, 2025 at 10:33:07AM -0600, Caleb Sander Mateos wrote:
> io_uring_cmd_prep() currently has two checks for whether
> IORING_URING_CMD_FIXED and IORING_URING_CMD_MULTISHOT are both set in
> uring_cmd_flags. Remove the second check.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
>  io_uring/uring_cmd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
> index 3cfb5d51b88a..c8fd204f6892 100644
> --- a/io_uring/uring_cmd.c
> +++ b/io_uring/uring_cmd.c
> @@ -200,12 +200,10 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
>  			return -EINVAL;
>  		req->buf_index = READ_ONCE(sqe->buf_index);
>  	}
>  
>  	if (ioucmd->flags & IORING_URING_CMD_MULTISHOT) {
> -		if (ioucmd->flags & IORING_URING_CMD_FIXED)
> -			return -EINVAL;
>  		if (!(req->flags & REQ_F_BUFFER_SELECT))
>  			return -EINVAL;
>  	} else {
>  		if (req->flags & REQ_F_BUFFER_SELECT)
>  			return -EINVAL;

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming