From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dixit Parmar <dixitparmar19@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Crt Mori" <cmo@melexis.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 02/10] iio: adc: Drop unnecessary -ENOMEM messages
Date: Fri, 22 Aug 2025 12:41:18 +0300 [thread overview]
Message-ID: <aKg7Ptj4jy4Icvgo@smile.fi.intel.com> (raw)
In-Reply-To: <20250822-enomam_logs-v1-2-db87f2974552@gmail.com>
On Fri, Aug 22, 2025 at 09:19:50AM +0530, Dixit Parmar wrote:
> The drivers do not require their own error messages for error
> -ENOMEM, memory allocation failures. So remove the dev_err
> messages from the probe().
...
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*ddata));
> - if (!indio_dev) {
> - dev_err(&pdev->dev, "failed to allocate iio device\n");
> -
> + if (!indio_dev)
> return -ENOMEM;
> - }
> +
> ddata = iio_priv(indio_dev);
> ddata->ato = device_get_match_data(&pdev->dev);
> if (!ddata->ato)
Looking at this hunk I'm wondering if you are using --histogram diff algo when
preparing patches. If not, please do for the next version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-22 9:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 3:49 [PATCH 00/10] iio: Drop unnecessary -ENOMEM messages Dixit Parmar
2025-08-22 3:49 ` [PATCH 01/10] iio: accel: " Dixit Parmar
2025-08-22 9:39 ` Andy Shevchenko
2025-08-22 3:49 ` [PATCH 02/10] iio: adc: " Dixit Parmar
2025-08-22 9:41 ` Andy Shevchenko [this message]
2025-08-22 3:49 ` [PATCH 03/10] iio: dac: " Dixit Parmar
2025-08-25 11:31 ` Jonathan Cameron
2025-08-22 3:49 ` [PATCH 04/10] iio: health: " Dixit Parmar
2025-08-25 11:35 ` Jonathan Cameron
2025-08-22 3:49 ` [PATCH 05/10] iio: humidity: " Dixit Parmar
2025-08-22 3:49 ` [PATCH 06/10] iio: light: " Dixit Parmar
2025-08-22 3:49 ` [PATCH 07/10] iio: potentiostat: " Dixit Parmar
2025-08-22 3:49 ` [PATCH 08/10] iio: pressure: " Dixit Parmar
2025-08-22 3:49 ` [PATCH 09/10] iio: proximity: " Dixit Parmar
2025-10-02 16:24 ` ChaosEsque Team
2025-08-22 3:49 ` [PATCH 10/10] iio: temperature: " Dixit Parmar
2025-08-22 6:19 ` [PATCH 00/10] iio: " Andy Shevchenko
2025-08-22 9:28 ` Dixit Parmar
2025-08-22 9:37 ` Andy Shevchenko
2025-08-25 8:31 ` Jonathan Cameron
2025-08-25 11:39 ` Jonathan Cameron
2025-08-26 2:42 ` Dixit Parmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKg7Ptj4jy4Icvgo@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cai.huoqing@linux.dev \
--cc=cmo@melexis.com \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.