From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
<igt-dev@lists.freedesktop.org>,
Martin Monroy <martin.monroy@intel.com>,
Karthik Poosa <karthik.poosa@intel.com>
Subject: Re: [PATCH i-g-t] tests/xe_pm: Ensure we open as primary for setting display off
Date: Fri, 22 Aug 2025 12:24:01 -0400 [thread overview]
Message-ID: <aKiZofKkMflw-LXC@intel.com> (raw)
In-Reply-To: <20250820163802.wsarifled2rl3bvm@kamilkon-DESK.igk.intel.com>
On Wed, Aug 20, 2025 at 06:38:02PM +0200, Kamil Konieczny wrote:
> Hi Rodrigo,
> On 2025-08-19 at 20:21:05 -0400, Rodrigo Vivi wrote:
>
> please add 'intel/' after 'tests/' so it will be:
>
> [PATCH i-g-t] tests/intel/xe_pm: Ensure we open as primary for setting display off
>
> This could be done at merge time.
Thank you for addressing that and merging it.
>
> > We need to ensure that no one else is using the display
> > so we can turn it off and guarantee it will drop all the
> > references.
> >
> > Cc: Martin Monroy <martin.monroy@intel.com>
> > Cc: Karthik Poosa <karthik.poosa@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > tests/intel/xe_pm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> > index 46b441c4d..a3a26f62a 100644
> > --- a/tests/intel/xe_pm.c
> > +++ b/tests/intel/xe_pm.c
> > @@ -145,7 +145,7 @@ static void vram_d3cold_threshold_restore(int sig)
> > {
> > int fd, sysfs_fd;
> >
> > - fd = drm_open_driver(DRIVER_XE);
> > + fd = drm_open_driver_master(DRIVER_XE);
>
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> > sysfs_fd = igt_sysfs_open(fd);
> >
> > set_vram_d3cold_threshold(sysfs_fd, orig_threshold);
> > --
> > 2.50.1
> >
next prev parent reply other threads:[~2025-08-22 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 0:21 [PATCH i-g-t] tests/xe_pm: Ensure we open as primary for setting display off Rodrigo Vivi
2025-08-20 1:18 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-08-20 1:26 ` ✓ Xe.CI.BAT: success " Patchwork
2025-08-20 16:38 ` [PATCH i-g-t] " Kamil Konieczny
2025-08-22 16:24 ` Rodrigo Vivi [this message]
2025-08-20 21:48 ` ✗ Xe.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKiZofKkMflw-LXC@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.poosa@intel.com \
--cc=martin.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.