From: Christoph Hellwig <hch@infradead.org>
To: alexjlzheng@gmail.com
Cc: brauner@kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, Jinliang Zheng <alexjlzheng@tencent.com>
Subject: Re: [PATCH v3 0/4] allow partial folio write with iomap_folio_state
Date: Mon, 25 Aug 2025 02:34:30 -0700 [thread overview]
Message-ID: <aKwuJptHVsx-Ed82@infradead.org> (raw)
In-Reply-To: <20250812091538.2004295-1-alexjlzheng@tencent.com>
On Tue, Aug 12, 2025 at 05:15:34PM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
>
> With iomap_folio_state, we can identify uptodate states at the block
> level, and a read_folio reading can correctly handle partially
> uptodate folios.
>
> Therefore, when a partial write occurs, accept the block-aligned
> partial write instead of rejecting the entire write.
>
> For example, suppose a folio is 2MB, blocksize is 4kB, and the copied
> bytes are 2MB-3kB.
I'd still love to see some explanation of why you are doing this.
Do you have a workload that actually hits this regularly, and where
it makes a difference. Can you provide numbers to quantify them?
next prev parent reply other threads:[~2025-08-25 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 9:15 [PATCH v3 0/4] allow partial folio write with iomap_folio_state alexjlzheng
2025-08-12 9:15 ` [PATCH v3 1/4] iomap: make sure iomap_adjust_read_range() are aligned with block_size alexjlzheng
2025-08-12 9:15 ` [PATCH v3 2/4] iomap: move iter revert case out of the unwritten branch alexjlzheng
2025-08-12 9:15 ` [PATCH v3 3/4] iomap: make iomap_write_end() return the number of written length again alexjlzheng
2025-08-12 9:15 ` [PATCH v3 4/4] iomap: don't abandon the whole copy when we have iomap_folio_state alexjlzheng
2025-08-25 6:41 ` [PATCH v3 0/4] allow partial folio write with iomap_folio_state Jinliang Zheng
2025-08-25 9:34 ` Christoph Hellwig [this message]
2025-08-25 11:39 ` Jinliang Zheng
2025-08-26 13:20 ` Christoph Hellwig
2025-09-11 9:17 ` Jinliang Zheng
2025-09-12 7:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKwuJptHVsx-Ed82@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.