From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Andrew Davis <afd@ti.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Hari Nagalla <hnagalla@ti.com>, Beleswar Padhi <b-padhi@ti.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] remoteproc: da8xx: Use devm_rproc_alloc() helper
Date: Mon, 25 Aug 2025 11:01:46 -0600 [thread overview]
Message-ID: <aKyW-oMAZR791GF2@p14s> (raw)
In-Reply-To: <20250814135532.638040-1-afd@ti.com>
On Thu, Aug 14, 2025 at 08:55:30AM -0500, Andrew Davis wrote:
> Use the device lifecycle managed allocation function. This helps prevent
> mistakes like freeing out of order in cleanup functions and forgetting to
> free on error paths.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
Applied.
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 93031f0867d10..47df21bea5254 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -276,8 +276,8 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> return dev_err_probe(dev, ret, "device does not have specific CMA pool\n");
> }
>
> - rproc = rproc_alloc(dev, "dsp", &da8xx_rproc_ops, da8xx_fw_name,
> - sizeof(*drproc));
> + rproc = devm_rproc_alloc(dev, "dsp", &da8xx_rproc_ops, da8xx_fw_name,
> + sizeof(*drproc));
> if (!rproc) {
> ret = -ENOMEM;
> goto free_mem;
> @@ -294,7 +294,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
>
> ret = da8xx_rproc_get_internal_memories(pdev, drproc);
> if (ret)
> - goto free_rproc;
> + goto free_mem;
>
> platform_set_drvdata(pdev, rproc);
>
> @@ -304,7 +304,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> rproc);
> if (ret) {
> dev_err(dev, "devm_request_threaded_irq error: %d\n", ret);
> - goto free_rproc;
> + goto free_mem;
> }
>
> /*
> @@ -314,7 +314,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> */
> ret = reset_control_assert(dsp_reset);
> if (ret)
> - goto free_rproc;
> + goto free_mem;
>
> drproc->chipsig = chipsig;
> drproc->bootreg = bootreg;
> @@ -325,13 +325,11 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> ret = rproc_add(rproc);
> if (ret) {
> dev_err(dev, "rproc_add failed: %d\n", ret);
> - goto free_rproc;
> + goto free_mem;
> }
>
> return 0;
>
> -free_rproc:
> - rproc_free(rproc);
> free_mem:
> if (dev->of_node)
> of_reserved_mem_device_release(dev);
> @@ -352,7 +350,6 @@ static void da8xx_rproc_remove(struct platform_device *pdev)
> disable_irq(drproc->irq);
>
> rproc_del(rproc);
> - rproc_free(rproc);
> if (dev->of_node)
> of_reserved_mem_device_release(dev);
> }
> --
> 2.39.2
>
prev parent reply other threads:[~2025-08-25 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:55 [PATCH 1/3] remoteproc: da8xx: Use devm_rproc_alloc() helper Andrew Davis
2025-08-14 13:55 ` [PATCH 2/3] remoteproc: da8xx: Use devm action to release reserved memory Andrew Davis
2025-08-25 17:04 ` Mathieu Poirier
2025-08-25 18:29 ` Andrew Davis
2025-08-26 18:48 ` Mathieu Poirier
2025-08-14 13:55 ` [PATCH 3/3] remoteproc: da8xx: Use devm_rproc_add() helper Andrew Davis
2025-08-25 17:01 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKyW-oMAZR791GF2@p14s \
--to=mathieu.poirier@linaro.org \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=b-padhi@ti.com \
--cc=hnagalla@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.