From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493E023BF96 for ; Mon, 25 Aug 2025 17:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756141457; cv=none; b=n70eoKXrCrkaZ+QY8cLV2US/hW/oGcIgBoylDALUqimVAWDDOw9XCijpz9eaQw8UEJBIXdoqxigaPR+tjsqj7iaDs1VfuwyOdnstmMdOvSU0V/r+oQ1rxBsNvHc6O86KH1hqtLKknCuHNlKTjkj3/EAyqQcyKXYPRl85AX1q/hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756141457; c=relaxed/simple; bh=bjMd344q5N5pg4iTG/2tiNcHP5sFWJ/LN69d/Fwd570=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DF2ahp/NG2ZKov9ZTI97nNX9qk4bjteDeO1lCfRkxdcZtJKGvESml9B70Ur6NojZrkV+k4OUL4hshf3SfcKRxIul0SnJAz/7vv+JvIIRdPT9JEC7JXrIM8acysiScnoHvf3ZY5KV2GXqWmP06BumkqGbNO4qRoPO/5l+3mxZAnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ar4qc99A; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ar4qc99A" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7704f3c46ceso1425073b3a.2 for ; Mon, 25 Aug 2025 10:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756141455; x=1756746255; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/9baOducWk07zRHRmC5T13Bf7TGkxoCIjk+kLvTMf9U=; b=ar4qc99AVdrQJQ7Fi47YNWkRQSNWtIYz4CWXwue/0hHtrA8T1XlqKXrXyUGt0NO3lD /N0snQv8bDfMIsgNB9gTRUvqZXdpZTKA/M41CN4ZLJ4NyCPAwca0oHaizFLZQt3waYKm SsYO7e6fUvcoFgIr6nVM5aoCpirS+VgmJCz/YfLja5uQBrnHP7SsfppkvbMiS/k2mfjq u3ouLwO9awovLqeexBH8AYeWseMWG9FzSjoGgbmLUVfUNBoo25ORdg+NUKZtjzt6kTkL hu+n3+/t8+X5ABmMmIc9exgIey8wJioUT3PryXLcCh52ynTs6QOsZYklcTxJ7MtKKkO5 1BzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756141455; x=1756746255; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/9baOducWk07zRHRmC5T13Bf7TGkxoCIjk+kLvTMf9U=; b=RbEYa3yE+3x4HjBG31oxjK3dXPE0s4KWSxIOfEebm8GIpZ6tuzXtD39/BNqlCl2K8w d33QPfNKmBJ+yiPjgpzT88a1hiDHe7yMWVGcj55cAHW8GmY1/j/oMD8PhERnsxyhk74y LiUI7BCjKZP6Z+zOh/oJOtW9mfU2nN449R7UV6pUV2Pa2curvDxvUBepMMZj1/azbFvl 31tsv4Bm3LwVch1l1dmn6c/m6wVOhThcZ80g4XpranSITyDp4qsoJWpgieaE1d2qlaXT 1/2XNK9QmnIGqCXqSo2k1qFZbgZq5j5+HcC9gD9gQ5hbKZFEVXuGSihEa38Yl5ThY/QS dRxg== X-Forwarded-Encrypted: i=1; AJvYcCXaXiI4gvBS8o9eEKGKTECo9z0oiS+ydtwi4rYGBeEAq9UDBFUkUaR82IrSMOh5ahyqA2KZ8XCd4Qg7p0VGRQqz@vger.kernel.org X-Gm-Message-State: AOJu0YxEaUuyrdyunVkU7OIWwN5cSyRdutSLb+vDeC9QG8/Dfp6LyElb kSUZWQbm4GVYJ8tvbuD9mtCuYcSkZIPL0kUO1DXJgdBfBssgoO2k+BE283z6WP4BPzw= X-Gm-Gg: ASbGncs9tP6dXYR7IdyMNhEfDqkyZ6P8ZC5Omk9MxDYNkXFgAlrdnPJP80bqhS9jBY3 PdrEGmUthfOkTPZJpUShbK7FUg/Vj8nr5s/3cCK+yaC21hlgbSqDdI4woIdEeDgv2vdFlBphAnp C0BaCf/r2yvUc9xG+fN1WILgq5rZ9nuOv9TKvglFWdT0iq8TkzUkiNHurJj027rqka+uumqDL2r Si0S6HNgnRONxEKiw8rXNjoV1ALb/e5sAM+Nq1iz73oaxDXMWwyLxsG4M9DclKQA/777yiXZoHy iNr9+s35yuIA28zfi7FosETzdZE1ED64IfHKr/71qHxD6L4QsDHlPEwQwNr3VD9eYnwCm9qQmjO HdaWghgnEFK3BihizIiub2ZogOjzMCjFx/7ugcTojV9jpg8D+OLn4ctLlIbgFmMhK1wAs4rfwWV VM4Jas2g6FHsElr1kz/EwQ60WP X-Google-Smtp-Source: AGHT+IGIjRD4vnI2qkQHnIDHuFVbnlSg4ZRwRIfz8qCZLAs2k7tIRdtAflzgUDlm/uVMUzjlSMhbow== X-Received: by 2002:a05:6a00:1991:b0:770:3ef5:1caf with SMTP id d2e1a72fcca58-7703ef51d86mr12958397b3a.24.1756141455561; Mon, 25 Aug 2025 10:04:15 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:f3a7:cbcf:8fdd:91a8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7705647e03esm4881985b3a.59.2025.08.25.10.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 10:04:15 -0700 (PDT) Date: Mon, 25 Aug 2025 11:04:12 -0600 From: Mathieu Poirier To: Andrew Davis Cc: Bjorn Andersson , Hari Nagalla , Beleswar Padhi , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] remoteproc: da8xx: Use devm action to release reserved memory Message-ID: References: <20250814135532.638040-1-afd@ti.com> <20250814135532.638040-2-afd@ti.com> Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814135532.638040-2-afd@ti.com> On Thu, Aug 14, 2025 at 08:55:31AM -0500, Andrew Davis wrote: > This helps prevent mistakes like freeing out of order in cleanup functions > and forgetting to free on error paths. > > Signed-off-by: Andrew Davis > --- > drivers/remoteproc/da8xx_remoteproc.c | 30 +++++++++++++-------------- > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c > index 47df21bea5254..58b4f05283d92 100644 > --- a/drivers/remoteproc/da8xx_remoteproc.c > +++ b/drivers/remoteproc/da8xx_remoteproc.c > @@ -233,6 +233,13 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev, > return 0; > } > > +static void da8xx_rproc_mem_release(void *data) > +{ > + struct device *dev = data; > + The check for dev->of_node from "free_mem" is missing. I can add it if you agree. > + of_reserved_mem_device_release(dev); > +} > + > static int da8xx_rproc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -274,14 +281,13 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > ret = of_reserved_mem_device_init(dev); > if (ret) > return dev_err_probe(dev, ret, "device does not have specific CMA pool\n"); > + devm_add_action_or_reset(&pdev->dev, da8xx_rproc_mem_release, &pdev->dev); > } > > rproc = devm_rproc_alloc(dev, "dsp", &da8xx_rproc_ops, da8xx_fw_name, > sizeof(*drproc)); > - if (!rproc) { > - ret = -ENOMEM; > - goto free_mem; > - } > + if (!rproc) > + return -ENOMEM; > > /* error recovery is not supported at present */ > rproc->recovery_disabled = true; > @@ -294,7 +300,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > > ret = da8xx_rproc_get_internal_memories(pdev, drproc); > if (ret) > - goto free_mem; > + return ret; > > platform_set_drvdata(pdev, rproc); > > @@ -304,7 +310,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > rproc); > if (ret) { > dev_err(dev, "devm_request_threaded_irq error: %d\n", ret); > - goto free_mem; > + return ret; > } > > /* > @@ -314,7 +320,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > */ > ret = reset_control_assert(dsp_reset); > if (ret) > - goto free_mem; > + return ret; > > drproc->chipsig = chipsig; > drproc->bootreg = bootreg; > @@ -325,22 +331,16 @@ static int da8xx_rproc_probe(struct platform_device *pdev) > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed: %d\n", ret); > - goto free_mem; > + return ret; > } > > return 0; > - > -free_mem: > - if (dev->of_node) > - of_reserved_mem_device_release(dev); > - return ret; > } > > static void da8xx_rproc_remove(struct platform_device *pdev) > { > struct rproc *rproc = platform_get_drvdata(pdev); > struct da8xx_rproc *drproc = rproc->priv; > - struct device *dev = &pdev->dev; > > /* > * The devm subsystem might end up releasing things before > @@ -350,8 +350,6 @@ static void da8xx_rproc_remove(struct platform_device *pdev) > disable_irq(drproc->irq); > > rproc_del(rproc); > - if (dev->of_node) > - of_reserved_mem_device_release(dev); > } > > static const struct of_device_id davinci_rproc_of_match[] __maybe_unused = { > -- > 2.39.2 >