From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 110AFCA101F for ; Mon, 8 Sep 2025 02:37:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1114464.1461373 (Exim 4.92) (envelope-from ) id 1uvRkz-0006ZG-Pv; Mon, 08 Sep 2025 02:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1114464.1461373; Mon, 08 Sep 2025 02:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uvRkz-0006Z9-MS; Mon, 08 Sep 2025 02:37:25 +0000 Received: by outflank-mailman (input) for mailman id 1114464; Mon, 08 Sep 2025 02:37:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uvRkz-0006Z3-AQ for xen-devel@lists.xenproject.org; Mon, 08 Sep 2025 02:37:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uvRkx-00D1dL-35; Mon, 08 Sep 2025 02:37:24 +0000 Received: from [19.12.91.86] (helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvRkx-0032oH-2v; Mon, 08 Sep 2025 02:37:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:Date:From; bh=1JnmaM64m5deykk9pXOMOarxzpQksjh+tlOOJDuej+A=; b= EFR88S09qaqP1ZjhStKrRpiDKEvkDUtFlcUuAERDio6RIluIT/VHNYxGWLwW/31Icdz3+q/BiKJ3f Bnz07Xwb/hOJwPOozGmytfjyuZf/jVwlgUjPluREjT276Ih0n9dv+ScpQhxcdkW5wJ5jDblsDRfid T+G3sL7A8ODqgwxR8=; From: dmukhin@xen.org Date: Sun, 7 Sep 2025 19:37:23 -0700 To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, dmukhin@ford.com Subject: Re: [PATCH v6 06/15] emul/ns16x50: implement IER/IIR registers Message-ID: References: <20250905232715.440758-1-dmukhin@ford.com> <20250905232715.440758-7-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 05, 2025 at 06:42:13PM -0700, Stefano Stabellini wrote: > On Fri, 5 Sep 2025, dmukhin@xen.org wrote: [..] > > +static void ns16x50_irq_assert(const struct vuart_ns16x50 *vdev) > > +{ > > + struct domain *d = vdev->owner; > > + const struct vuart_info *info = vdev->info; > > + int vector; > > + > > + if ( has_vpic(d) ) > > + vector = hvm_isa_irq_assert(d, info->irq, vioapic_get_vector); > > + else > > + ASSERT_UNREACHABLE(); > > This seems dangerous as there are guests without vpic Agreed; will update.