Re: [PATCH] ui/spice: fix crash when disabling GL scanout on

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Sep 03, 2025 at 11:38:18PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> When spice_qxl_gl_scanout2() isn't available, the fallback code
> incorrectly handles NULL arguments to disable the scanout, leading to:
> 
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0  spice_server_gl_scanout (qxl=0x55a25ce57ae8, fd=0x0, width=0, height=0, offset=0x0, stride=0x0, num_planes=0, format=0, modifier=72057594037927935, y_0_top=0)
>     at ../ui/spice-display.c:983
> 983         if (num_planes <= 1) {
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2391334
> Fixes: 98a050ca93afd8 ("ui/spice: support multi plane dmabuf scanout")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/spice-display.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|