All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
	Dan Winship <danwinship@redhat.com>
Subject: Re: [nft PATCH] table: Embed creating nft version into userdata
Date: Mon, 8 Sep 2025 14:07:05 +0200	[thread overview]
Message-ID: <aL7G6aI4M74hgS8Z@calendula> (raw)
In-Reply-To: <aL7GEObOxcH1z4Rb@calendula>

On Mon, Sep 08, 2025 at 02:03:51PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 13, 2025 at 07:07:19PM +0200, Phil Sutter wrote:
> > Upon listing a table which was created by a newer version of nftables,
> > warn about the potentially incomplete content.
> 
> Compilation breaks for me here:
> 
> In file included from src/netlink.c:13:
> ./nftversion.h:6:20: error: 'MAKE_STAMP' undeclared here (not in a function)
>     6 |         ((uint64_t)MAKE_STAMP >> 56) & 0xff,
>       |                    ^~~~~~~~~~

It breaks when I compile with:

make V=1 CFLAGS+="-fsanitize=address -fsanitize=undefined" -j 16

which I usually do, including valgrind runs, to catch for memory
issues.

Could you look into restoring this? Thanks!

  reply	other threads:[~2025-09-08 12:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 17:07 [nft PATCH] table: Embed creating nft version into userdata Phil Sutter
2025-08-13 17:21 ` Phil Sutter
2025-08-27 22:46 ` Pablo Neira Ayuso
2025-08-28 10:48   ` Phil Sutter
2025-08-28 12:53 ` Pablo Neira Ayuso
2025-08-28 13:53   ` Phil Sutter
2025-08-28 14:45     ` Pablo Neira Ayuso
2025-09-08 12:03 ` Pablo Neira Ayuso
2025-09-08 12:07   ` Pablo Neira Ayuso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-08-08 12:46 Phil Sutter
2025-08-11 18:58 ` Pablo Neira Ayuso
2025-08-12 13:06   ` Phil Sutter
2025-08-12 13:17     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aL7G6aI4M74hgS8Z@calendula \
    --to=pablo@netfilter.org \
    --cc=danwinship@redhat.com \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.