From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D34ECAC586 for ; Mon, 8 Sep 2025 12:40:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1115198.1461901 (Exim 4.92) (envelope-from ) id 1uvbAG-00066e-Dd; Mon, 08 Sep 2025 12:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1115198.1461901; Mon, 08 Sep 2025 12:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uvbAG-00066X-Aq; Mon, 08 Sep 2025 12:40:08 +0000 Received: by outflank-mailman (input) for mailman id 1115198; Mon, 08 Sep 2025 12:40:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uvbAE-00066R-OX for xen-devel@lists.xenproject.org; Mon, 08 Sep 2025 12:40:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uvbAE-0004Oh-1Z; Mon, 08 Sep 2025 12:40:06 +0000 Received: from [2a01:cb15:80df:da00:e2a9:ff82:7bde:38cd] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uvbAE-000AqQ-1Q; Mon, 08 Sep 2025 12:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=LKrQf42PX7PPTfH1KO/Y9I8QjeGk+y1kUYYQZKxEP0w=; b=0vlEO8y6HHLg6PKRaSaMxk84oG AYvnx8fdewIejU2VDBVyyoDDD/wIOkBnE3YYYFoufYBY8EfLbx+BErtk+3xJu9FfORsGKBg7vSGfo Xmp4HIKor55Y8NLcMBFSS8mCGXEcgEi6qCD5IJQf17RwKUzh7z8ZGXR2fPutMWHFRJrQ=; Date: Mon, 8 Sep 2025 14:40:04 +0200 From: Anthony PERARD To: Jason Andryuk Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Anthony PERARD , Juergen Gross Subject: Re: [PATCH] libxl: preserve errno in libxl__xcinfo2xlinfo() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 27, 2025 at 09:16:38PM -0400, Jason Andryuk wrote: > On 2025-08-27 01:57, Jan Beulich wrote: > > Callers observing errors elsewhere may be confused by the ENOSYS that > > the Flask operation would yield on a Flask-disabled hypervisor. > > > > Signed-off-by: Jan Beulich > > --- > > Of course I don't know whether clobbering errno is perhaps deemed "fine" > > in libxl. > > I wonder if it would be better to special case libxl_flask_sid_to_context() > to preserve errno on ENOSYS. flask returning ENOSYS is common, but > libxl_flask_sid_to_context() can legitimately have error. Well, errno=ENOSYS gives information about why libxl_flask_sid_to_context() returns an error. They are multiple error code for returns libxl_*() functions but they aren't really check. We often rely on errno to print an error message. And in this case, libxl_flask_sid_to_context() doesn't event return a proper libxl_error value. > I guess this is fine if we want to use this approach: > > Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD Thanks, -- Anthony PERARD