From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sienna.cherry.relay.mailchannels.net (sienna.cherry.relay.mailchannels.net [23.83.223.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7B63126B0 for ; Mon, 8 Sep 2025 17:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.223.165 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757354182; cv=pass; b=ANbp5F62yhdYVC0WsiSpfj0NXA2GIXwZcpqyyrAuQ3s8Dt7sofPhxIA1lqs+6ji3B+qxI6bR8Qi1j5l6grhGuUZfyMe0crRU6LFVQrEfAUwad1f+UHYhV1f1LWrGDHV/lA8rIxHuccMFZ3wsyfIYv0HQI8PU7jCHJmNPp+uDWms= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757354182; c=relaxed/simple; bh=P/J8Q5DYQYuStvC6Bc73MAqlu8BUvqjwHti8m+/JaQQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vFTFYDFvJjWmPXXRXSXOmTF6s0Gv4i/GqNqtBpVBMmut1XVIwJSEjSvM81ZlNClhAsn8E4WPYCc9b0XsAdr8HVrG2bAXRtXirSobf2u9Qm3pLE/GchPA1YS3Reh0BSVA6cxsiwV3ObareQz+ZiS7S/k/x/IP+Pd1/xa0lGWONmo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=templeofstupid.com; spf=pass smtp.mailfrom=templeofstupid.com; dkim=pass (2048-bit key) header.d=templeofstupid.com header.i=@templeofstupid.com header.b=oTwcWaK2; arc=pass smtp.client-ip=23.83.223.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=templeofstupid.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=templeofstupid.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=templeofstupid.com header.i=@templeofstupid.com header.b="oTwcWaK2" X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A6A17322171 for ; Mon, 8 Sep 2025 17:56:19 +0000 (UTC) Received: from pdx1-sub0-mail-a204.dreamhost.com (100-107-19-249.trex-nlb.outbound.svc.cluster.local [100.107.19.249]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 24EC832302C for ; Mon, 8 Sep 2025 17:56:19 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1757354179; a=rsa-sha256; cv=none; b=likiF5Pz+l24cpi1HDw0vLDK/HqNQ8kN6Od4cyWPhLXyYno3WPlS/Po0aVZzsb2PPG/m8/ JoH7GuBnRb5HwMzyCn+SKJi7aEtKE8SHPKm79fcK0NihVIrNJslCg0RrjypDOX2adMBVp/ z1HMuCh/ImeFZZzCsW6oAa9DO6gc0A1wQRUbE++7zjl8LvP8vfXW4kcGzQRJsC0CG4Ysnv pfRKLLaFTbydlrN4MKM7pVxgC8plOtVJ6ZY2QM6eUnBy9yeRzR2cxlQFzaC3Y8uTbrPtit ZHWk3OboM/DjKPxdCaBmyBa7dzMSjzZ65Vl29+UrI8Beb0N/PvECvHaVJB0sjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1757354179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AjGVOBGP1+0JyYOyX6xCbtYcMOxH1qnoHVFbeUfubMo=; b=xoDNf5PyyUn+LP3msgWk83Ydq/I9kt9rDVf/o+4u9/6ainAgPjTT9L90tonJmQ/a90O6Nw dK3PGCFpb3AN2d8+a+Fxol/9JJJA2MSjmJ0TapCcgi8jSpqaLkZG6aBCejioHGx6kxRiWV m0Zl6KShqrFZBBsEqwdUeOoc9yqnRB3sX0aAm1Y4WNHWMz1FfjcL7Fm+lHEQhXLLiUUgHw FBG4pIZi/k0jxSSqlskU4bVao6XAKLDxUmN2+Hsu0KXob8zHO9jLkkyzuei0PfgGM+9mte RVltNWT8eeykEPtCIw5bJQccEWPUWR65Cd0FSm5KUGij8a/yfEPUIexAhT5Yuw== ARC-Authentication-Results: i=1; rspamd-9968f48fc-xqc6l; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Battle-Continue: 08bdc694707cb125_1757354179361_2020638930 X-MC-Loop-Signature: 1757354179360:1018353559 X-MC-Ingress-Time: 1757354179360 Received: from pdx1-sub0-mail-a204.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.19.249 (trex/7.1.3); Mon, 08 Sep 2025 17:56:19 +0000 Received: from kmjvbox.templeofstupid.com (c-73-70-109-47.hsd1.ca.comcast.net [73.70.109.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a204.dreamhost.com (Postfix) with ESMTPSA id 4cLF4f2rCjzm5 for ; Mon, 8 Sep 2025 10:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1757354178; bh=AjGVOBGP1+0JyYOyX6xCbtYcMOxH1qnoHVFbeUfubMo=; h=Date:From:To:Cc:Subject:Content-Type:Content-Transfer-Encoding; b=oTwcWaK21N5kITtrVxD5p6EZojXyCi8T1Zfja/XVTHa987hjNMb8EDK6gIA3cm2/c KUdFQ6eXXe9vgt9EduoqzVYEPmjgvzIl7ymoJ/nEpsZCQ1lbka+GfFASqtQK4srD7l qSz0RwwyfCld76fhJ3hzpIbZijA4ecCbc/fvaPCJgZMrKStlFMcR8oq6M86lqHFfF/ 3D7L/kEXbQkgdO652dsZ7g0hn9fxj9WQt6GIylRetxmJ/w47jIsvfA7T0T66WmRvB3 IbeOny7EgRBE1Sz1aLxfG1AjW+H1f6dFJ1dBr4EJi11c16T44PXAZOO/tetNLO5amg QEyVg/NCHxmbQ== Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0263 by kmjvbox.templeofstupid.com (DragonFly Mail Agent v0.13); Mon, 08 Sep 2025 10:56:16 -0700 Date: Mon, 8 Sep 2025 10:56:16 -0700 From: Krister Johansen To: Matthieu Baerts Cc: Geliang Tang , Mat Martineau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Florian Westphal , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, David Reaver Subject: Re: [PATCH mptcp] mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN Message-ID: References: <83191d507b7bc9b0693568c2848319932e6b974e.camel@kernel.org> <78d4a7b8-8025-493a-805c-a4c5d26836a8@kernel.org> <23a66a02-7de9-40c5-995d-e701cb192f8b@kernel.org> <575893ce-11a8-492f-ac8c-5995b3e90c76@kernel.org> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <575893ce-11a8-492f-ac8c-5995b3e90c76@kernel.org> On Mon, Sep 08, 2025 at 07:51:10PM +0200, Matthieu Baerts wrote: > 8 Sept 2025 19:45:32 Krister Johansen : > > > On Mon, Sep 08, 2025 at 07:31:43PM +0200, Matthieu Baerts wrote: > >> Hi Krister, > >> > >> On 08/09/2025 19:25, Krister Johansen wrote: > >>> On Mon, Sep 08, 2025 at 07:13:12PM +0200, Matthieu Baerts wrote: > >>>> Hi Geliang, > >>>> > >>>> On 07/09/2025 02:51, Geliang Tang wrote: > >>>>> Hi Matt, > >>>>> > >>>>> On Sat, 2025-09-06 at 15:26 +0200, Matthieu Baerts wrote: > >>>>>> … > >>>>> > >>>>> nit: > >>>>> > >>>>> I just noticed his patch breaks 'Reverse X-Mas Tree' order in > >>>>> sync_socket_options(). If you think any changes are needed, please > >>>>> update this when you re-send it. > >>>> > >>>> Sure, I can do the modification and send it with other fixes we have. > >>> > >>> Thanks for the reviews, Geliang and Matt.  If you'd like me to fix the > >>> formatting up and send a v2, I'm happy to do that as well.  Just let me > >>> know. > >> > >> I was going to apply this diff: > >> > >>> diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c > >>> index 13108e9f982b..2abe6f1e9940 100644 > >>> --- a/net/mptcp/sockopt.c > >>> +++ b/net/mptcp/sockopt.c > >>> @@ -1532,11 +1532,12 @@ static void sync_socket_options(struct mptcp_sock *msk, struct sock *ssk) > >>> { > >>>         static const unsigned int tx_rx_locks = SOCK_RCVBUF_LOCK | SOCK_SNDBUF_LOCK; > >>>         struct sock *sk = (struct sock *)msk; > >>> -       int kaval = !!sock_flag(sk, SOCK_KEEPOPEN); > >>> +       bool keep_open; > >>> > >>> +       keep_open = sock_flag(sk, SOCK_KEEPOPEN); > >>>         if (ssk->sk_prot->keepalive) > >>> -               ssk->sk_prot->keepalive(ssk, kaval); > >>> -       sock_valbool_flag(ssk, SOCK_KEEPOPEN, kaval); > >>> +               ssk->sk_prot->keepalive(ssk, keep_open); > >>> +       sock_valbool_flag(ssk, SOCK_KEEPOPEN, keep_open); > >>> > >>>         ssk->sk_priority = sk->sk_priority; > >>>         ssk->sk_bound_dev_if = sk->sk_bound_dev_if; > >> > >> (sock_flag() returns a bool, and 'keep_open' is maybe clearer) > >> > >> But up to you, I really don't mind if you prefer to send the v2 by > >> yourself, just let me know. > > > > Thanks, I'll go ahead and amend as you suggest and then send a v2. > > Great, thanks. > > While at it, please use [PATCH net] as prefix. Thanks, will do. May I preserve the Reveiwed-By tags from the v1, or would you like to review again? -K