Re: [PATCH v2 06/18] python: backport 'qmp-shell: add common_parser()'

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 08, 2025 at 01:39:58PM -0400, John Snow wrote:
> On Mon, Sep 8, 2025 at 12:47 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Sep 03, 2025 at 01:11:12AM -0400, John Snow wrote:
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> > > cherry picked from commit 20a88c2471f37d10520b2409046d59e1d0f1e905
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> >
> > Duplicate s-o-b
> 
> One is from the original commit, the other is from the backport.
> Wasn't sure if that was truly needed, but figured it wouldn't hurt
> anything.

Yes, I realized when looking at later commits, that's fine.

> 
> >
> > > ---
> > >  python/qemu/qmp/qmp_shell.py | 35 ++++++++++++++++-------------------
> > >  1 file changed, 16 insertions(+), 19 deletions(-)
> >
> > Wierdly the diffstat when I looked qmp_shell.py is very different
> > from what your patch here shows, but the end result appears the
> > same. Perhaps one of us has different settings for $HOME/.gitconfig
> > that affects diff display
> 
> Possible. I didn't exactly take care to preserve the commits
> themselves exactly as they were ...



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|