From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: "Fabian Bläse" <fabian@blaese.de>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH v3] icmp: fix icmp_ndo_send address translation for reply direction
Date: Thu, 28 Aug 2025 14:48:04 +0200 [thread overview]
Message-ID: <aLBQBPdYE9pNmXOy@strlen.de> (raw)
In-Reply-To: <aLBMktniIkqsfWQY@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > So I believe its needed, concurrent update of ->status is possible and
> > KCSAN would warn. Other spots either use READ_ONCE or use test_bit().
>
> There are a more checks for ct->status & NAT_MASK in the tree that I
> can see, if you are correct, then maybe a new helper function to check
> for NAT_MASK is needed.
I think it would make sense to add a helper, yes.
Independent of this patch of course.
next prev parent reply other threads:[~2025-08-28 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 20:17 [PATCH] icmp: fix icmp_ndo_send address translation for reply direction Fabian Bläse
2025-08-25 20:38 ` [PATCH v2] " Fabian Bläse
2025-08-27 9:05 ` Florian Westphal
2025-08-27 17:12 ` Fabian Bläse
2025-08-27 17:25 ` Florian Westphal
2025-08-28 9:14 ` [PATCH v3] " Fabian Bläse
2025-08-28 12:00 ` Pablo Neira Ayuso
2025-08-28 12:15 ` Florian Westphal
2025-08-28 12:33 ` Pablo Neira Ayuso
2025-08-28 12:48 ` Florian Westphal [this message]
2025-08-28 12:48 ` Florian Westphal
2025-09-01 20:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLBQBPdYE9pNmXOy@strlen.de \
--to=fw@strlen.de \
--cc=Jason@zx2c4.com \
--cc=fabian@blaese.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.