All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Sven Auhagen <Sven.Auhagen@belden.com>
Subject: Re: [PATCH nf-next v2 1/2] netfilter: nf_tables: allow iter callbacks to sleep
Date: Fri, 29 Aug 2025 01:46:32 +0200	[thread overview]
Message-ID: <aLDqWArd2zByoICJ@strlen.de> (raw)
In-Reply-To: <aLBxa0V0b5QbTZzC@strlen.de>

Florian Westphal <fw@strlen.de> wrote:
> > Not causing any harm, but is iter->count useful for this
> > NFT_ITER_UPDATE variant?
> >
> > I think iter->count is only used for netlink dumps, to resume from the
> > last netlink message.
> 
> Yes. Should I just remove the above or also add a WARN_ON_ONCE(iter->skip) ...

FTR, I removed the iterator and placed the WARN_ON_ONCE

> > > +	switch (iter->type) {
> > > +	case NFT_ITER_UPDATE:

here, then pushed this to nf-next:testing.

  reply	other threads:[~2025-08-28 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  8:15 [PATCH nf-next v2 0/2] netfilter: nf_tables: avoid atomic allocations for set flush Florian Westphal
2025-08-22  8:15 ` [PATCH nf-next v2 1/2] netfilter: nf_tables: allow iter callbacks to sleep Florian Westphal
2025-08-28 14:30   ` Pablo Neira Ayuso
2025-08-28 15:10     ` Florian Westphal
2025-08-28 23:46       ` Florian Westphal [this message]
2025-08-22  8:15 ` [PATCH nf-next v2 2/2] netfilter: nf_tables: all transaction allocations can now sleep Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLDqWArd2zByoICJ@strlen.de \
    --to=fw@strlen.de \
    --cc=Sven.Auhagen@belden.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.