All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Huang Rui <ray.huang@amd.com>
Subject: Re: [PATCH v11 1/5] vpci: Use cleanup to free capability resource during deassign
Date: Fri, 29 Aug 2025 12:07:26 +0200	[thread overview]
Message-ID: <aLF73jSo3IUUGFJ_@Mac.lan> (raw)
In-Reply-To: <20250808080337.28609-2-Jiqian.Chen@amd.com>

On Fri, Aug 08, 2025 at 04:03:33PM +0800, Jiqian Chen wrote:
> As cleanup hook of all supported capabilities will be implemented in
> follow-on changes, so to pre-call hook in vpci_deassign_device(), and
> the capability specific clean open-code in there will be removed by
> follow-on corresponding capability changes.
> 
> Since vpci_deassign_device() and vpci_init_capabilities() require
> different cleanup actions, add a boolean parameter to cleanup hook
> to distinguish them.
> 
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>

I think it's missing:

Requested-by: Jan Beulich <jbeulich@suse.com>

With the newline below added:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I can do it on commit.

Thanks, Roger.


  parent reply	other threads:[~2025-08-29 10:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08  8:03 [PATCH v11 0/5] Support hiding capability when its initialization fails Jiqian Chen
2025-08-08  8:03 ` [PATCH v11 1/5] vpci: Use cleanup to free capability resource during deassign Jiqian Chen
2025-08-08  8:58   ` Jan Beulich
2025-08-11  4:04     ` Chen, Jiqian
2025-08-11  7:24       ` Jan Beulich
2025-08-29 10:07   ` Roger Pau Monné [this message]
2025-08-08  8:03 ` [PATCH v11 2/5] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-08-29 10:09   ` Roger Pau Monné
2025-08-08  8:03 ` [PATCH v11 3/5] vpci/rebar: Implement cleanup function for Rebar Jiqian Chen
2025-08-29 10:22   ` Roger Pau Monné
2025-09-10  9:32     ` Chen, Jiqian
2025-08-08  8:03 ` [PATCH v11 4/5] vpci/msi: Implement cleanup function for MSI Jiqian Chen
2025-08-29 10:29   ` Roger Pau Monné
2025-08-29 10:41   ` Roger Pau Monné
2025-09-10  9:57     ` Chen, Jiqian
2025-08-08  8:03 ` [PATCH v11 5/5] vpci/msix: Implement cleanup function for MSI-X Jiqian Chen
2025-08-29 11:06   ` Roger Pau Monné
2025-09-10 10:11     ` Chen, Jiqian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLF73jSo3IUUGFJ_@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=ray.huang@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.