From: Alice Ryhl <aliceryhl@google.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: use the new name Location::file_as_c_str() in rustc 1.91.0+
Date: Fri, 29 Aug 2025 08:36:10 +0000 [thread overview]
Message-ID: <aLFmenCq6fICWaA6@google.com> (raw)
In-Reply-To: <aK8co_CHsqr4gBhe@tardis-2.local>
On Wed, Aug 27, 2025 at 07:56:35AM -0700, Boqun Feng wrote:
> On Wed, Aug 27, 2025 at 01:12:16PM +0000, Alice Ryhl wrote:
> > As part of the stabilization of Location::file_with_nul(), it was
> > brought up that the with_nul() suffix usually means something else in
> > Rust APIs, so the API is being renamed prior to stabilization. Thus,
> > adjust Linux to use the new name on new rustc versions.
> >
> > Link: https://www.github.com/rust-lang/rust/pull/145928 [1]
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>
> Thanks for doing this!
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
>
> > ---
> > This hasn't been merged upstream yet. It shouldn't be merged until that
> > happens.
>
> Let me know when it gets upstreamed, I'm happy to do a test then.
The PR just landed.
Alice
next prev parent reply other threads:[~2025-08-29 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 13:12 [PATCH] rust: use the new name Location::file_as_c_str() in rustc 1.91.0+ Alice Ryhl
2025-08-27 14:56 ` Boqun Feng
2025-08-29 8:36 ` Alice Ryhl [this message]
2025-08-31 21:39 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLFmenCq6fICWaA6@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.