Re: [PATCH] tests/functional/m68k: Avoid ResourceWarning in the nextcube test

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Aug 29, 2025 at 04:20:00PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Since commit c3fd296cf7b1 ("functional: always enable all python
> warnings") we enabled more warnings for the functional tests. This
> triggers now a warning in the nextcube test:
> 
>  tests/functional/m68k/test_nextcube.py:47: ResourceWarning:
>   unclosed file <_io.BufferedReader name='tests/functional/m68k/test_nextcube.NextCubeMachine.test_bootrom_framebuffer_size/scratch/dump.ppm'>
>    width, height = Image.open(screenshot_path).size
> 
> Use a proper "with" context to avoid it.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/m68k/test_nextcube.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|