All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] mount_setattr01: add open_tree_attr variant
Date: Fri, 29 Aug 2025 14:55:56 +0200	[thread overview]
Message-ID: <aLGjXEcSFhzqLiUd@rei.lan> (raw)
In-Reply-To: <9f626db7-5bf0-4376-8b4a-a643569f41ab@suse.com>

Hi!
> > The tst_variant was implemented exactly for the case where we have
> > different syscalls doing the same job. In this case a shortcut was added
> > that does open_tree + mount_setattr in a single syscall, so using
> > variants is very reasonable choice.
> 
> Is it a free for all to merge the patch?

And does it work correctly on kernels older than 6.15? I do not see any
checks for the open_tree_attr() syscall availability.

Apart from that there are a few minor things to fix, I will do a proper
review.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-08-29 12:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 13:11 [LTP] [PATCH 0/2] open_tree_attr syscall coverage Andrea Cervesato
2025-08-28 13:11 ` [LTP] [PATCH 1/2] Add open_tree_attr fallback Andrea Cervesato
2025-08-28 13:11 ` [LTP] [PATCH 2/2] mount_setattr01: add open_tree_attr variant Andrea Cervesato
2025-08-28 23:08   ` Wei Gao via ltp
2025-08-29  9:31     ` Cyril Hrubis
2025-08-29 12:06       ` Andrea Cervesato via ltp
2025-08-29 12:55         ` Cyril Hrubis [this message]
2025-09-01 10:28           ` Andrea Cervesato via ltp
2025-09-01 15:48             ` Cyril Hrubis
2025-08-29 12:06     ` Andrea Cervesato via ltp
2025-08-29 12:58   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLGjXEcSFhzqLiUd@rei.lan \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.