From: Phil Sutter <phil@nwl.cc>
To: Zhen Ni <zhen.ni@easystack.cn>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Remove unused htable_bits in macro ahash_region
Date: Fri, 29 Aug 2025 15:21:10 +0200 [thread overview]
Message-ID: <aLGpRloVpz6SnMvB@orbyte.nwl.cc> (raw)
In-Reply-To: <20250829083621.1630638-1-zhen.ni@easystack.cn>
On Fri, Aug 29, 2025 at 04:36:21PM +0800, Zhen Ni wrote:
> Since the ahash_region() macro was redefined to calculate the region
> index solely from HTABLE_REGION_BITS, the htable_bits parameter became
> unused.
>
> Remove the unused htable_bits argument and its call sites, simplifying
> the code without changing semantics.
>
> Fixes: 8478a729c046 ("netfilter: ipset: fix region locking in hash types")
> Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
Reviewed-by: Phil Sutter <phil@nwl.cc>
prev parent reply other threads:[~2025-08-29 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 8:36 [PATCH] netfilter: ipset: Remove unused htable_bits in macro ahash_region Zhen Ni
2025-08-29 13:21 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLGpRloVpz6SnMvB@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.