All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Michal Orzel <michal.orzel@amd.com>
Subject: Re: [PATCH v2 5/5] symbols: prefer symbols which have a type
Date: Fri, 29 Aug 2025 17:13:43 +0200	[thread overview]
Message-ID: <aLHDpyuUipkL2shD@Mac.lan> (raw)
In-Reply-To: <8ec4b804-28d0-4f39-8d2e-29d326a6909c@amd.com>

On Wed, Aug 27, 2025 at 09:07:50PM -0400, Jason Andryuk wrote:
> On 2025-04-02 10:00, Jan Beulich wrote:
> > ... and thus typically also a size. Using global vs local is undesirable
> > in certain situations, e.g. when a "real" symbol is local and at the
> > same address as a section start/end one (which are all global).
> > 
> > Note that for xen.efi the checking for "Function" is only forward-
> > looking at this point: The function-ness of symbols (much like their
> > size) is lost when linking PE/COFF binaries from ELF objects with GNU ld
> > up to at least 2.44.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


      reply	other threads:[~2025-08-29 15:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 13:56 [PATCH v2 0/5] symbols: assorted adjustments Jan Beulich
2025-04-02 13:57 ` [PATCH v2 1/5] symbols: add minimal self-test Jan Beulich
2025-08-27 22:20   ` Jason Andryuk
2025-08-29 14:24   ` Roger Pau Monné
2025-09-01  6:38     ` Jan Beulich
2025-04-02 13:58 ` [PATCH v2 2/5] symbols: split symbols_num_syms Jan Beulich
2025-08-27 22:20   ` Jason Andryuk
2025-04-02 13:58 ` [PATCH v2 3/5] symbols: arrange to know where functions end Jan Beulich
2025-04-02 14:08   ` Jan Beulich
2025-08-28  1:03   ` Jason Andryuk
2025-08-28  7:28     ` Jan Beulich
2025-08-28 16:11       ` Jan Beulich
2025-08-28 17:16         ` Jason Andryuk
2025-08-29  6:59           ` Jan Beulich
2025-08-31 14:50             ` Jason Andryuk
2025-04-02 13:59 ` [PATCH v2 4/5] symbols: centralize and re-arrange $(all_symbols) calculation Jan Beulich
2025-08-28  1:05   ` Jason Andryuk
2025-08-29 15:02     ` Roger Pau Monné
2025-04-02 14:00 ` [PATCH v2 5/5] symbols: prefer symbols which have a type Jan Beulich
2025-08-28  1:07   ` Jason Andryuk
2025-08-29 15:13     ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLHDpyuUipkL2shD@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=jason.andryuk@amd.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.