From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Yuanchu Xie <yuanchu@google.com>
Cc: Max Kellermann <max.kellermann@ionos.com>,
akpm@linux-foundation.org, david@redhat.com,
axelrasmussen@google.com, willy@infradead.org, hughd@google.com,
mhocko@suse.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com
Subject: Re: [PATCH 01/12] mm/shmem: add `const` to lots of pointer parameters
Date: Fri, 29 Aug 2025 15:52:10 -0700 [thread overview]
Message-ID: <aLIvGsEvXSoNDbKl@fedora> (raw)
In-Reply-To: <CAJj2-QHVC0QW_4X95LLAnM=1g6apH==-OXZu65SVeBj0tSUcBg@mail.gmail.com>
On Fri, Aug 29, 2025 at 03:44:12PM -0500, Yuanchu Xie wrote:
> On Fri, Aug 29, 2025 at 1:32 PM Max Kellermann <max.kellermann@ionos.com> wrote:
> >
> > For improved const-correctness.
> >
> > Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> Reviewed-by: Yuanchu Xie <yuanchu@google.com>
>
> Appreciate the work. On a side note, Andrew previously mentioned[1]
> making the actual parameter value const (which is different from
> adding the const qualifier to the pointer). Longer function
> readability would benefit from that, but it's IMO infeasible to do so
> everywhere.
+1
> [1] https://lore.kernel.org/lkml/20250827144832.87d2f1692fe61325628710f4@linux-foundation.org/#r
Imo the lack of these value const's isn't a blocker, but it'd be nice to
do that "For improved const-correctness". Especially when you're changing the
line anyways (see mapping_tagged() or folio_contains()).
next prev parent reply other threads:[~2025-08-29 22:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 18:31 [PATCH 00/12] mm: add `const` to lots of pointer parameters Max Kellermann
2025-08-29 18:31 ` [PATCH 01/12] mm/shmem: " Max Kellermann
2025-08-29 20:44 ` Yuanchu Xie
2025-08-29 22:52 ` Vishal Moola (Oracle) [this message]
2025-08-29 22:45 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 02/12] include/pagemap.h: " Max Kellermann
2025-08-29 22:55 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 03/12] include/mmzone.h: " Max Kellermann
2025-08-29 22:56 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 04/12] include/fs.h: add `const` to several " Max Kellermann
2025-08-29 23:11 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 05/12] mm/oom_kill: add `const` to pointer parameter Max Kellermann
2025-08-29 23:03 ` Vishal Moola (Oracle)
2025-08-30 6:26 ` Max Kellermann
2025-08-31 1:49 ` Andrew Morton
2025-08-29 18:31 ` [PATCH 06/12] mm/util: add `const` to several pointer parameters Max Kellermann
2025-08-29 23:10 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 07/12] parisc/sys_parisc.c: add `const` to mmap_upper_limit() parameter Max Kellermann
2025-08-29 23:13 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 08/12] arch, mm/util: add const to arch_pick_mmap_layout() parameter Max Kellermann
2025-08-29 23:36 ` Vishal Moola (Oracle)
2025-08-31 9:07 ` Max Kellermann
2025-08-30 16:03 ` kernel test robot
2025-08-30 17:26 ` kernel test robot
2025-08-29 18:31 ` [PATCH 09/12] include/mm_types.h: add `const` to several pointer parameters Max Kellermann
2025-08-29 23:37 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 10/12] include/mm_inline.h: add `const` to lots of " Max Kellermann
2025-08-29 23:37 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 11/12] include/mm.h: " Max Kellermann
2025-08-29 18:31 ` [PATCH 12/12] mm/highmem: " Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLIvGsEvXSoNDbKl@fedora \
--to=vishal.moola@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=max.kellermann@ionos.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.