From: Waldemar Brodkorb <wbx@openadk.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/asterisk: fix build caused by libjwt bump
Date: Sat, 30 Aug 2025 07:00:11 +0200 [thread overview]
Message-ID: <aLKFW9aM7cTdELxw@waldemar-brodkorb.de> (raw)
In-Reply-To: <20250829235155.721a4774@windsurf>
Hi Thomas,
Thomas Petazzoni wrote,
> On Fri, 29 Aug 2025 22:47:39 +0200
> Waldemar Brodkorb <wbx@openadk.org> wrote:
>
> > > Waldemar: you did the bump of libjwt. Are you using this library?
> > > Independently of Asterisk?
> >
> > No, I am fine with that change.
>
> Sorry, but that doesn't really answer my question. You are both the
> maintainer of package/libjwt and package/asterisk, and you bumped
> package/libjwt, which is only used by package/asterisk, without testing
> that it doesn't break asterisk.
That is not true. I tested it. At least a basic test as always:
buildroot$ git checkout f11b9db0b5f150d73e10a0c25989e2ec6300588e
buildroot$ make raspberrypi5_defconfig
buildroot$ make menuconfig <- choose asterisk
buildroot$ make
buildroot$ file output/target/usr/sbin/asterisk
output/target/usr/sbin/asterisk: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, stripped
buildroot$ ./output/host/bin/aarch64-linux-gcc --version
aarch64-linux-gcc.br_real (Buildroot 2021.11-12449-g1bef613319) 13.3.0
The reason for the failures might be a newer gcc.
> Now that asterisk uses a bundled libjwt, do we need to keep the
> separate libjwt package?
No, for me it is okay to use the bundled one and remove the separate
package.
best regards
Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-30 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 17:05 [Buildroot] [PATCH] package/asterisk: fix build caused by libjwt bump Thomas Petazzoni via buildroot
2025-08-29 20:47 ` Waldemar Brodkorb
2025-08-29 21:51 ` Thomas Petazzoni via buildroot
2025-08-30 5:00 ` Waldemar Brodkorb [this message]
2025-08-30 6:51 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLKFW9aM7cTdELxw@waldemar-brodkorb.de \
--to=wbx@openadk.org \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.