Re: [PATCH v7 04/14] target/riscv: Add MIPS P8700 CSRs

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 01, 2025 at 10:29:02AM +0000, Djordje Todorovic wrote:
> Define MIPS CSRs used for P8700 CPU.
> 
> Signed-off-by: Chao-ying Fu <cfu@mips.com>
> Signed-off-by: Djordje Todorovic <djordje.todorovic@htecgroup.com>
> Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
>  target/riscv/cpu.c       |   3 +
>  target/riscv/cpu.h       |   3 +
>  target/riscv/meson.build |   1 +
>  target/riscv/mips_csr.c  | 228 +++++++++++++++++++++++++++++++++++++++
>  4 files changed, 235 insertions(+)
>  create mode 100644 target/riscv/mips_csr.c

> diff --git a/target/riscv/mips_csr.c b/target/riscv/mips_csr.c
> new file mode 100644
> index 0000000000..2fc10b8618
> --- /dev/null
> +++ b/target/riscv/mips_csr.c
> @@ -0,0 +1,228 @@
> +/*
> + * MIPS-specific CSRs.
> + *
> + * Copyright (c) 2025 MIPS
> + *
> + * SPDX-License-Identifier: LGPL-2.1-or-later

What is the reason for this choice ?

New files are expected to be GPL-2.0-or-later, with any divergence
from this explained in the commit message.


> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2 or later, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program.  If not, see <http://www.gnu.org/licenses/>.

This should not be present on newly authored files - only pre-existing
code which predated our use of SPDX tags, because it creates the possible
problem of inconsistent license details - which is what you have here.

This is saying GPL-2.0-or-later, while the SDPX tag says LGPL-2.1-or-later

These points apply to multiple patches in this series.

Please make sure to run 'checkpatch.pl' on patches before submissions,
as it would have reported these problems.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|