From: Mike Rapoport <rppt@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: Kiryl Shutsemau <kirill@shutemov.name>,
akpm@linux-foundation.org, david@redhat.com,
axelrasmussen@google.com, yuanchu@google.com,
willy@infradead.org, hughd@google.com, mhocko@suse.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, surenb@google.com, vishal.moola@gmail.com
Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters
Date: Mon, 1 Sep 2025 12:01:59 +0300 [thread overview]
Message-ID: <aLVhB4qQMurjS1Ap@kernel.org> (raw)
In-Reply-To: <CAKPOu+-ZjNr9hEir8H=C5C9ZwbS7ynY4PrJuvnxa-V425A+U3Q@mail.gmail.com>
On Mon, Sep 01, 2025 at 10:05:53AM +0200, Max Kellermann wrote:
> On Mon, Sep 1, 2025 at 9:33 AM Kiryl Shutsemau <kirill@shutemov.name> wrote:
> >
> > On Sun, Aug 31, 2025 at 11:39:07AM +0200, Max Kellermann wrote:
> > > For improved const-correctness.
> >
> > It is not a proper commit message.
>
> I believe it is proper for something as trivial as this. I think
> adding more text would just be noise, only wasting the time of people
> reading it. But that is a matter of perspective: I expect every
> competent C developer to know the concept of const-correctness.
True, but having a brief explanation why it's ok to constify these
parameters helps. Especially in longer patches.
> Do you believe the commit message of 29cfe7556bfd ("mm: constify more
> page/folio tests") is "proper"?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-09-01 9:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 9:39 [PATCH v2 00/12] mm: add `const` to lots of pointer parameters Max Kellermann
2025-08-31 9:39 ` [PATCH v2 01/12] mm/shmem: " Max Kellermann
2025-09-01 7:33 ` Kiryl Shutsemau
2025-09-01 8:05 ` Max Kellermann
2025-09-01 8:20 ` David Hildenbrand
2025-09-01 8:26 ` Max Kellermann
2025-09-01 8:35 ` David Hildenbrand
2025-09-01 9:26 ` Max Kellermann
2025-09-01 9:32 ` Vlastimil Babka
2025-09-01 9:45 ` Max Kellermann
2025-09-01 9:49 ` David Hildenbrand
2025-09-01 9:41 ` David Hildenbrand
2025-09-01 9:48 ` Max Kellermann
2025-09-01 9:52 ` David Hildenbrand
2025-09-01 10:00 ` Max Kellermann
2025-09-01 10:07 ` David Hildenbrand
2025-09-01 10:36 ` Max Kellermann
2025-09-01 10:40 ` David Hildenbrand
2025-09-01 9:01 ` Mike Rapoport [this message]
2025-08-31 9:39 ` [PATCH v2 02/12] include/pagemap.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 03/12] include/mmzone.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 04/12] include/fs.h: add `const` to several " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 05/12] mm/oom_kill: add `const` to pointer parameter Max Kellermann
2025-08-31 9:39 ` [PATCH v2 06/12] mm/util: add `const` to several pointer parameters Max Kellermann
2025-08-31 9:39 ` [PATCH v2 07/12] parisc/sys_parisc.c: add `const` to mmap_upper_limit() parameter Max Kellermann
2025-09-01 0:38 ` Matthew Wilcox
2025-09-01 6:06 ` Max Kellermann
2025-08-31 9:39 ` [PATCH v2 08/12] arch, mm/util: add const to arch_pick_mmap_layout() parameter Max Kellermann
2025-08-31 23:43 ` kernel test robot
2025-09-01 4:30 ` Max Kellermann
2025-08-31 9:39 ` [PATCH v2 09/12] include/mm_types.h: add `const` to several pointer parameters Max Kellermann
2025-08-31 9:39 ` [PATCH v2 10/12] include/mm_inline.h: add `const` to lots of " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 11/12] include/mm.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 12/12] mm/highmem: " Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLVhB4qQMurjS1Ap@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=max.kellermann@ionos.com \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.