From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Chinmay Rath" <rathc@linux.ibm.com>,
kvm@vger.kernel.org, "Glenn Miles" <milesg@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v2 2/3] buildsys: Prohibit alloca() use on system code
Date: Mon, 1 Sep 2025 14:37:45 +0100 [thread overview]
Message-ID: <aLWhqb7Kc59N3jGx@redhat.com> (raw)
In-Reply-To: <20250901132626.28639-3-philmd@linaro.org>
On Mon, Sep 01, 2025 at 03:26:25PM +0200, Philippe Mathieu-Daudé wrote:
> Similarly to commit 64c1a544352 ("meson: Enable -Wvla") with
> variable length arrays, forbid alloca() uses on system code.
>
> There are few uses on ancient linux-user code, do not bother
> there.
This says you're not turning on -Walloca for linux-user, but....
> +if have_system
> + warn_flags += ['-Walloca']
> +endif
...surely this still turns on -Walloca for linux-user, if the build has
enabled multiple targets covering both system & user mode. ie a default
qemu build ?
> +
> # Set up C++ compiler flags
> qemu_cxxflags = []
> if 'cpp' in all_languages
> --
> 2.51.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-01 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 13:26 [PATCH v2 0/3] system: Forbid alloca() Philippe Mathieu-Daudé
2025-09-01 13:26 ` [PATCH v2 1/3] target/ppc/kvm: Avoid using alloca() Philippe Mathieu-Daudé
2025-09-01 13:30 ` Peter Maydell
2025-09-01 14:07 ` Manos Pitsidianakis
2025-09-02 6:41 ` Harsh Prateek Bora
2025-09-02 14:05 ` Stefan Hajnoczi
2025-09-01 13:26 ` [PATCH v2 2/3] buildsys: Prohibit alloca() use on system code Philippe Mathieu-Daudé
2025-09-01 13:37 ` Daniel P. Berrangé [this message]
2025-09-01 13:26 ` [PATCH v2 3/3] docs/devel/style: Mention alloca() family API is forbidden Philippe Mathieu-Daudé
2025-09-01 14:05 ` Manos Pitsidianakis
2025-09-01 14:41 ` Philippe Mathieu-Daudé
2025-09-02 14:04 ` Stefan Hajnoczi
2025-09-02 10:17 ` [PATCH v2 0/3] system: Forbid alloca() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLWhqb7Kc59N3jGx@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=milesg@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.