All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Isaac Oscar Gariano <isaacoscar@live.com.au>
Subject: Re: [PATCH v2 0/4] oddities around add-interactive and color
Date: Tue, 9 Sep 2025 08:09:02 +0200	[thread overview]
Message-ID: <aL_EfmRj_zDC_8xm@pks.im> (raw)
In-Reply-To: <20250908164157.GA1323487@coredump.intra.peff.net>

On Mon, Sep 08, 2025 at 12:41:57PM -0400, Jeff King wrote:
> On Thu, Aug 21, 2025 at 03:07:40AM -0400, Jeff King wrote:
> 
> > So here's a series which I think addresses everything I found. These
> > bugs have been lurking for a while, but I guess not many people tend to
> > set color variables to anything exotic.
> 
> And here's a v2 based on Patrick's review. I also touched up a few lines
> whose indentation did not pass clang-format (not new, but ones I was
> touching or moving around). The only thing I punted on was refactoring
> the GIT_COLOR_* defines, as I think it extends well beyond the code I'm
> touching here (see the reply I left in the thread).

Thanks, this addresses all of my feedback from v1. Well, except the
GIT_COLOR_* defines, but I agree that it doesn't make sense to do that
as part of this series.

Patrick

      parent reply	other threads:[~2025-09-09  6:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 11:05 [BUG] Some subcommands ignore color.diff and color.ui in --patch mode Isaac Oscar Gariano
2025-08-20 22:04 ` Jeff King
2025-08-20 23:48   ` Isaac Oscar Gariano
2025-08-21  7:00     ` Jeff King
2025-08-21  7:07   ` [PATCH 0/4] oddities around add-interactive and color Jeff King
2025-08-21  7:15     ` [PATCH 1/4] stash: pass --no-color to diff-tree child processes Jeff King
2025-09-03  7:23       ` Patrick Steinhardt
2025-09-08 16:06         ` Jeff King
2025-08-21  7:19     ` [PATCH 2/4] add-interactive: respect color.diff for diff coloring Jeff King
2025-09-03  7:23       ` Patrick Steinhardt
2025-09-08 16:16         ` Jeff King
2025-09-09  6:06           ` Patrick Steinhardt
2025-08-21  7:22     ` [PATCH 3/4] add-interactive: manually fall back color config to color.ui Jeff King
2025-08-21 15:42       ` Junio C Hamano
2025-09-03  7:23       ` Patrick Steinhardt
2025-09-08 16:17         ` Jeff King
2025-08-21  7:22     ` [PATCH 4/4] contrib/diff-highlight: mention interactive.diffFilter Jeff King
2025-09-08 16:41     ` [PATCH v2 0/4] oddities around add-interactive and color Jeff King
2025-09-08 16:42       ` [PATCH v2 1/4] stash: pass --no-color to diff plumbing child processes Jeff King
2025-09-08 16:42       ` [PATCH v2 2/4] add-interactive: respect color.diff for diff coloring Jeff King
2025-09-08 16:42       ` [PATCH v2 3/4] add-interactive: manually fall back color config to color.ui Jeff King
2025-09-08 16:42       ` [PATCH v2 4/4] contrib/diff-highlight: mention interactive.diffFilter Jeff King
2025-09-09  6:09       ` Patrick Steinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aL_EfmRj_zDC_8xm@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=isaacoscar@live.com.au \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.