Re: [RFC] staging: media: atomisp: Simplyfy masking bit logic

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Sep 02, 2025 at 12:02:29PM +0300, Dan Carpenter wrote:
> On Tue, Sep 02, 2025 at 07:38:40AM +0000, Adrian Barnaś wrote:

...

> >  static inline hive_uedge
> >  inv_subword(hive_uedge w, unsigned int start, unsigned int end)
> >  {
> > -	return w & (~(((1ULL << (end - 1)) - 1) << 1 | 1) | ((1ULL << start) - 1));
> > +	return w & (~__GENMASK_ULL(end-1, start));
> >  }
> 
> nit: white space.  Add spaces.  Remove parentheses.
> 
> These are supposed to be opposites, right?  Subword and inverse Subword.
> You could dress them up to make them look more opposite.
> 
> 	return (w & __GENMASK_ULL(end - 1, start)) >> start;
> 	return w & ~__GENMASK_ULL(end - 1, start);

The problem is (and actually with the (end-1, start) above that it might
generate a really bad code on some CPUs, so I really, really prefer the way
when _at least_ one of the parameters is constant.
That said, using

	GENMASK_ULL(end - 1, 0)

in both cases makes also them look more similar (and opposition comes on how
start is being used).

-- 
With Best Regards,
Andy Shevchenko