Re: [PATCH] tick: Remove unreasonable detached state set in tick_shutdown()

[Frederic Weisbecker <frederic@kernel.org>]

Le Mon, Aug 11, 2025 at 11:57:20AM +0800, Bibo Mao a écrit :
> Hi,
> 
> Previously tick_shutdown() is called in BP, percpu timer cannot be shutdown
> in BP. Now it is called in AP, percpu timer can be shutdown in AP itself.

Ok, one more reason for not backporting it to stable then.

> 
> And there is another method, like other architectures add hotplug event
> callbak to shutdown percpu timer such as CPUHP_AP_LOONGARCH_TIMER_STARTING.
> 
> Which one do you prefer?

I prefer your fix that works for every clockevents. We want the active clockevent
to be stopped by the time we reach CPUHP_AP_OFFLINE.

If you add a loongarch hotplug callback, it must be for architecture
specifics.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs