From: Cyril Hrubis <chrubis@suse.cz>
To: "Ricardo B. Marlière" <rbm@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v5 3/4] syscalls: lchown02: Convert to new API
Date: Tue, 2 Sep 2025 16:20:20 +0200 [thread overview]
Message-ID: <aLb9JFildIcrsu7v@yuki.lan> (raw)
In-Reply-To: <20250829-conversions-lchown-v5-3-7c3f25cd1de4@suse.com>
Hi!
> + UID16_CHECK((user_id = geteuid()), "lchown");
> + GID16_CHECK((group_id = getegid()), "lchown");
The test does not change the uid/git during it's run so user_id and
group_id can be checked and initialized once in the test setup. We also
set it to ltpuser ids so we know the value there as well.
Anyways that is very minor so with that fixed:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-02 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 21:01 [LTP] [PATCH v5 0/4] syscalls: lchown: Convert to new API Ricardo B. Marlière via ltp
2025-08-29 21:02 ` [LTP] [PATCH v5 1/4] lib: Add SAFE_LCHOWN Ricardo B. Marlière via ltp
2025-08-29 21:02 ` [LTP] [PATCH v5 2/4] syscalls: lchown01: Convert to new API Ricardo B. Marlière via ltp
2025-09-02 13:41 ` Cyril Hrubis
2025-08-29 21:02 ` [LTP] [PATCH v5 3/4] syscalls: lchown02: " Ricardo B. Marlière via ltp
2025-09-02 14:20 ` Cyril Hrubis [this message]
2025-08-29 21:02 ` [LTP] [PATCH v5 4/4] syscalls: lchown03: Merge into lchown02 Ricardo B. Marlière via ltp
2025-09-02 14:27 ` Cyril Hrubis
2025-09-09 14:48 ` Ricardo B. Marlière via ltp
2025-09-10 15:51 ` Cyril Hrubis
2025-09-10 16:26 ` Cyril Hrubis
2025-09-10 22:16 ` Ricardo B. Marlière via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLb9JFildIcrsu7v@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.