From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Akshay Jindal <akshayaj.lkd@gmail.com>
Cc: anshulusr@gmail.com, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, shuah@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iio: light: ltr390: Implement runtime PM support
Date: Tue, 2 Sep 2025 15:59:17 +0300 [thread overview]
Message-ID: <aLbqJfGiHWNhXfgx@smile.fi.intel.com> (raw)
In-Reply-To: <aLbptFRh9ZvAVfLn@smile.fi.intel.com>
On Tue, Sep 02, 2025 at 03:57:24PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 02, 2025 at 12:12:36AM +0530, Akshay Jindal wrote:
...
> > + if (regmap_clear_bits(data->regmap, LTR390_INT_CFG,
> > + LTR390_LS_INT_EN) < 0)
>
> Wrong indentation, hard to read line, either one line, or do better. Actually
> why not assign it to ret? The above not only simple style issue, but also makes
> readability much harder as the semantics of '0' is completely hidden. This style
> is discouraged.
Noticing that this is existing style I recommend to have a precursor patch to
fix this and any other place like this first.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-02 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 18:42 [PATCH v4] iio: light: ltr390: Implement runtime PM support Akshay Jindal
2025-09-02 12:57 ` Andy Shevchenko
2025-09-02 12:59 ` Andy Shevchenko [this message]
2025-09-03 3:45 ` Akshay Jindal
2025-09-03 10:37 ` Andy Shevchenko
2025-09-03 11:27 ` Akshay Jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLbqJfGiHWNhXfgx@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akshayaj.lkd@gmail.com \
--cc=andy@kernel.org \
--cc=anshulusr@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.