From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Hanna Reitz <hreitz@redhat.com>, Cleber Rosa <crosa@redhat.com>,
Qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH 00/19] python: 3.14 compatibility and python-qemu-qmp synchronization
Date: Tue, 2 Sep 2025 21:34:38 +0200 [thread overview]
Message-ID: <aLdGgmFMs76A_wJi@redhat.com> (raw)
In-Reply-To: <CAFn=p-bq42-CGHfNe=WENHQFTsCbD0iKNywYYqXkAM_Aq_aamA@mail.gmail.com>
On Tue, Sep 02, 2025 at 12:58:24PM -0400, John Snow wrote:
> On Tue, Sep 2, 2025, 12:54 PM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
> > On Mon, Sep 01, 2025 at 04:26:42PM -0400, John Snow wrote:
> > > RFC: Should I squash the last two backport patches? One technically
> > > introduces a regression which breaks our "no regressions in series"
> > > rule, but makes the per-patch relationship murkier. Please let me know.
> >
> > What is the effect of the regression ?
> >
> > If someone is running 'make check' (or a variant thereof), through
> > a "git bisect" will this regression be significant enough to break
> > their git bisect ?
> >
>
> It could, yes. To avoid it I need to squash the latest get_event_loop
> change in to the second-to-last one.
>
> I guess I'll just notate that it's cherry-picked from two commits and
> include both commit messages.
>
> Does that sound OK? (I've never really "cherry picked" across repositories
> like this where the file paths do not actually match, so it's been a bit of
> a manual affair.)
Yeah, just noting that its a combo of two commits sounds good to me.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2025-09-02 19:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 20:26 [PATCH 00/19] python: 3.14 compatibility and python-qemu-qmp synchronization John Snow
2025-09-01 20:26 ` [PATCH 01/19] python: backport 'Change error classes to have better repr methods' John Snow
2025-09-01 20:26 ` [PATCH 02/19] python: backport 'EventListener: add __repr__ method' John Snow
2025-09-01 20:26 ` [PATCH 03/19] python: backport 'kick event queue on legacy event_pull()' John Snow
2025-09-01 20:26 ` [PATCH 04/19] python: backport 'protocol: adjust logging name when changing client name' John Snow
2025-09-01 20:26 ` [PATCH 05/19] python: backport 'drop Python3.6 workarounds' John Snow
2025-09-01 20:26 ` [PATCH 06/19] python: backport 'qmp-shell: add common_parser()' John Snow
2025-09-01 20:26 ` [PATCH 07/19] python: backport 'feat: allow setting read buffer limit' John Snow
2025-09-01 20:26 ` [PATCH 08/19] python: backport 'make require() preserve async-ness' John Snow
2025-09-01 20:26 ` [PATCH 09/19] python: backport 'qmp-shell-wrap: handle missing binary gracefully' John Snow
2025-09-01 20:26 ` [PATCH 10/19] python: backport 'qmp-tui: Do not crash if optional dependencies are not met' John Snow
2025-09-01 20:26 ` [PATCH 11/19] python: backport 'Remove deprecated get_event_loop calls' John Snow
2025-09-01 20:26 ` [PATCH 12/19] python: backport '*really* remove get_event_loop' John Snow
2025-09-01 20:26 ` [PATCH 13/19] python: backport 'python: avoid creating additional event loops per thread' John Snow
2025-09-01 20:26 ` [PATCH 14/19] python: synchronize qemu.qmp documentation John Snow
2025-09-01 20:26 ` [PATCH 15/19] iotests: drop compat for old version context manager John Snow
2025-09-01 20:26 ` [PATCH 16/19] python: ensure QEMUQtestProtocol closes its socket John Snow
2025-09-01 20:26 ` [PATCH 17/19] iotests/147: ensure temporary sockets are closed before exiting John Snow
2025-09-01 20:27 ` [PATCH 18/19] iotests/151: ensure subprocesses are cleaned up John Snow
2025-09-01 20:27 ` [PATCH 19/19] iotests/check: always enable all python warnings John Snow
2025-09-02 16:54 ` [PATCH 00/19] python: 3.14 compatibility and python-qemu-qmp synchronization Daniel P. Berrangé
2025-09-02 16:58 ` John Snow
2025-09-02 19:34 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLdGgmFMs76A_wJi@redhat.com \
--to=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.