From: Dan Carpenter <dan.carpenter@linaro.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Kees Cook <kees@kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] mm: Fix kernel stack tagging for certain configs
Date: Tue, 2 Sep 2025 23:09:37 +0300 [thread overview]
Message-ID: <aLdPAa54rrZsOFm_@stanley.mountain> (raw)
In-Reply-To: <aLdFxtVpOX-qf0qc@casper.infradead.org>
On Tue, Sep 02, 2025 at 08:30:14PM +0100, Matthew Wilcox wrote:
> On Tue, Sep 02, 2025 at 10:59:03AM -0700, Vishal Moola (Oracle) wrote:
> > There are 3 cases where kernel pages are allocated for kernel stacks:
> > CONFIG_VMAP_STACK, THREAD_SIZE >= PAGE_SIZE, THREAD_SIZE < PAGE_SIZE.
> > These cases use vmalloc(), alloc_pages() and kmem_cache_alloc()
> > respectively.
>
> I missed that the third case existed ...
>
> > In the first 2 cases, THREAD_SIZE / PAGE_SIZE will always be greater
> > than 0, and pages are tagged as expected. In the third case,
> > THREAD_SIZE / PAGE_SIZE evaluates to 0 and doesn't tag any pages at all.
> > This meant that in those configs, the stack tagging was a no-op, and led
> > to smatch build warnings.
>
> I didn't see those smatch warnings. Were they cc'd to the mailing list?
>
I messed up and accidentally sent an email with two Message-ID headers
so maybe it got eaten by your spam filter?
https://lore.kernel.org/all/202508300929.TrRovUMu-lkp@intel.com/
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-02 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 17:59 [PATCH] mm: Fix kernel stack tagging for certain configs Vishal Moola (Oracle)
2025-09-02 18:23 ` David Hildenbrand
2025-09-02 20:06 ` Vishal Moola (Oracle)
2025-09-03 7:46 ` David Hildenbrand
2025-09-03 18:12 ` Vishal Moola (Oracle)
2025-09-04 6:38 ` David Hildenbrand
2025-09-02 19:30 ` Matthew Wilcox
2025-09-02 20:09 ` Dan Carpenter [this message]
2025-09-04 6:42 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLdPAa54rrZsOFm_@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.