From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v2 3/3] gpio: gpio-ltc4283: Add support for the LTC4283 Swap Controller
Date: Wed, 3 Sep 2025 13:26:55 +0200 [thread overview]
Message-ID: <aLgl_9X0_2082SkH@black.igk.intel.com> (raw)
In-Reply-To: <20250903-ltc4283-support-v2-3-6bce091510bf@analog.com>
On Wed, Sep 03, 2025 at 11:05:01AM +0100, Nuno Sá wrote:
> The LTC4283 device has up to 8 pins that can be configured as GPIOs.
>
> Note that PGIO pins are not set as GPIOs by default so if they are
> configured to be used as GPIOs we need to make sure to initialize them
> to a sane default. They are set as inputs by default.
...
> +/* Non-constant mask variant of FIELD_GET() and FIELD_PREP() */
> +#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
> +#define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
Can we eventually stop copy'n'paste these and put them to bitfield.h, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-03 11:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 10:04 [PATCH v2 0/3] hwmon: Add support for the LTC4283 Hot Swap Controller Nuno Sá
2025-09-03 10:04 ` Nuno Sá via B4 Relay
2025-09-03 10:04 ` [PATCH v2 1/3] dt-binbings: hwmon: Document the LTC4283 " Nuno Sá
2025-09-03 10:04 ` Nuno Sá via B4 Relay
2025-09-03 21:48 ` Rob Herring
2025-09-06 0:27 ` Guenter Roeck
2025-09-03 10:05 ` [PATCH v2 2/3] hwmon: ltc4283: Add support for " Nuno Sá
2025-09-03 10:05 ` Nuno Sá via B4 Relay
2025-09-04 21:30 ` kernel test robot
2025-09-06 1:24 ` Guenter Roeck
2025-09-12 14:00 ` Nuno Sá
2025-09-13 11:02 ` Guenter Roeck
2025-10-08 13:07 ` Nuno Sá
2025-10-08 14:11 ` Guenter Roeck
2025-10-08 14:45 ` Nuno Sá
2025-09-03 10:05 ` [PATCH v2 3/3] gpio: gpio-ltc4283: " Nuno Sá
2025-09-03 10:05 ` Nuno Sá via B4 Relay
2025-09-03 11:26 ` Andy Shevchenko [this message]
2025-09-09 10:27 ` Nuno Sá
2025-09-09 11:32 ` Andy Shevchenko
2025-09-04 2:42 ` Randy Dunlap
2025-09-04 19:57 ` Linus Walleij
2025-09-09 10:22 ` Nuno Sá
2025-09-09 10:25 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLgl_9X0_2082SkH@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.