From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11434CA1011 for ; Wed, 3 Sep 2025 17:01:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1108812.1458817 (Exim 4.92) (envelope-from ) id 1utqql-0007xu-RR; Wed, 03 Sep 2025 17:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1108812.1458817; Wed, 03 Sep 2025 17:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utqql-0007xn-OW; Wed, 03 Sep 2025 17:00:47 +0000 Received: by outflank-mailman (input) for mailman id 1108812; Wed, 03 Sep 2025 17:00:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1utqqk-0007xh-29 for xen-devel@lists.xenproject.org; Wed, 03 Sep 2025 17:00:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1utqqj-004gM4-0I; Wed, 03 Sep 2025 17:00:45 +0000 Received: from [2a01:e0a:1da:8420:b77:bd5:6e45:7633] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1utqqj-00EfpY-01; Wed, 03 Sep 2025 17:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=iEeNnU+R5bAInwKCWmP6SzRyhcG+xOojmDNTmaPqRLI=; b=5d1fbF8ZR41KkRyM5TWinR5xR2 2G1lVw/viUnvdYuA41BSmEh67eWrpuDX+N3C4aLTlk/Jh2+1SEuLpbok7T18dbZTpxEOO8RZHCVkl bWYXDFvSP+0i+JRoBbrGnm9910lVZRh6Ey4kQflBWIJS556EDnmT9fVC0neSL9wOpkFo=; Date: Wed, 3 Sep 2025 19:00:42 +0200 From: Anthony PERARD To: Jahan Murudi Cc: xen-devel@lists.xenproject.org, Anthony PERARD Subject: Re: [PATCH v4 2/4] xentop: add pcpu implementation with proper error handling Message-ID: References: <20250903102323.2553142-1-jahan.murudi.zg@renesas.com> <20250903102323.2553142-3-jahan.murudi.zg@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250903102323.2553142-3-jahan.murudi.zg@renesas.com> On Wed, Sep 03, 2025 at 03:53:21PM +0530, Jahan Murudi wrote: > diff --git a/tools/xentop/pcpu.c b/tools/xentop/pcpu.c > new file mode 100644 > index 0000000000..cdb4cb2131 > --- /dev/null > +++ b/tools/xentop/pcpu.c [..] > +/* Accessor functions for xentop.c */ > +int get_pcpu_count(void) > +{ > + return allocated_pcpus; > +} > + > +float get_pcpu_usage(int cpu_index) You could use `size_t` instead of `int` for the `cpu_index`, and then, no need to check for negatives. `allocated_pcpus` could also be `size_t` or `unsigned int`, since "0" mean not available, we don't need "-1" or other negative numbers. > +{ > + if (!pcpu_stats || cpu_index < 0 || cpu_index >= allocated_pcpus) { > + return 0.0; > + } > + return pcpu_stats[cpu_index].usage_pct; > +} Thanks, -- Anthony PERARD