Re: [PATCH] i2c: Main i2c-*.c files and algos/ subdirectory : Fix errors and warnings generated by checkpatch

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

On Wed, Sep 03, 2025 at 06:56:12PM +0200, Andi Shyti wrote:
> Hi Cezar,
> 
> On Sat, Aug 30, 2025 at 12:30:15PM +0300, Cezar Chiru wrote:
> > Fixed some coding style errors and warnings plus some minor changes
> > in code as reported by checkpatch script. The busses/ and muxes/
> > subfolders will be dealt with another commit. Main changes were done
> > to comments, defines of 'if' statement, swapping 'unsigned' with
> > 'unsigned int' and other minor changes.
> > 
> > Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
> > ---
> >  drivers/i2c/Kconfig              |  2 +-
> >  drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------
> >  drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++----
> >  drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++----------
> >  drivers/i2c/algos/i2c-algo-pcf.h | 10 +++---
> >  drivers/i2c/i2c-boardinfo.c      |  2 +-
> >  drivers/i2c/i2c-core-base.c      | 59 +++++++++++++++++++-----------
> >  drivers/i2c/i2c-dev.c            | 47 ++++++++++++++----------
> >  drivers/i2c/i2c-mux.c            |  1 +
> >  drivers/i2c/i2c-slave-eeprom.c   |  2 +-
> >  drivers/i2c/i2c-smbus.c          |  2 +-
> >  drivers/i2c/i2c-stub.c           | 29 +++++++--------
> >  12 files changed, 170 insertions(+), 99 deletions(-)
> 
> first of all, thanks for your patch, but I can't accept it.
> Please split your patch in several smaller patches with single
> changes.
> 
> Granularity is very important for reviews and git blame.

Same comment as previous patch: describe testing please


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]