Re: [PATCH v6.17-rc] perf test: Checking BPF metadata collection fails on version string

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Fri, Aug 22, 2025 at 11:02:27AM -0700, Ian Rogers wrote:
> On Fri, Aug 22, 2025 at 5:26 AM Thomas Richter <tmricht@linux.ibm.com> wrote:
> > commit edf2cadf01e8f ("perf test: add test for BPF metadata collection")

> > fails consistently on the version string check. The perf version
> > string on some of the constant integration test machines contains
> > characters with special meaning in grep's extended regular expression
> > matching algorithm. The output of perf version is:

> >  # perf version
> >  perf version 6.17.0-20250814.rc1.git20.24ea63ea3877.63.fc42.s390x+git

> > and the '+' character has special meaning in egrep command.
> > Also the use of egrep is deprecated.

> > Change the perf version string check to fixed character matching
> > and get rid of egrep's warning being deprecated. Use grep -F instead.

<SNIP>

> > Fixes: edf2cadf01e8f ("perf test: add test for BPF metadata collection")
> > Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> > Acked-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
> > Cc: Blake Jones <blakejones@google.com>
 
> Reviewed-by: Ian Rogers <irogers@google.com>

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Namhyung, I think this should go into v6.17-rc.

Thanks,

- Arnaldo