Re: [PATCH v2 1/3] dt-bindings: gpio: loongson: Document GPIO controller of 2K0300 SoC

[Yao Zi <ziyao@disroot.org>]

Hi Huacai,

On Mon, Sep 01, 2025 at 02:58:54PM +0000, Yao Zi wrote:
> On Mon, Sep 01, 2025 at 10:22:04PM +0800, Huacai Chen wrote:
> > Hi, Yao,
> > 
> > On Mon, Sep 1, 2025 at 9:38 PM Yao Zi <ziyao@disroot.org> wrote:
> > >
> > > Loongson 2K0300 ships a GPIO controller whose input/output control logic
> > > is similar to previous generation of SoCs. Additionally, it acts as an
> > > interrupt-controller supporting both level and edge interrupts and has a
> > > distinct reset signal.
> > >
> > > Describe its compatible in devicetree. We enlarge the maximum value of
> > > ngpios to 128, since the controller technically supports at most 128
> > > pins, although only 106 are routed out of the package. Properties for
> > > interrupt-controllers and resets are introduced and limited as 2K0300
> > > only.
> > Replace the full name with "Loongson-2K0300" and short name with
> > "LS2K0300", others look good to me.
> > Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> 
> I don't understand what is improved with this. For the fullname, I don't
> see any difference between "Loongson 2K0300" and "Loongson-2K0300". And
> for the short one, omitting the "LS" prefix doesn't introduce any
> ambiguity, either.
> 
> I did a quick search through git log, and found many commits for Loongson
> 2K SoCs do include a hyphen for the fullname and "LS" prefix for
> abbreviation in messages, while some merge commits don't do so.
> 
> Even the official production page for Loongson 2K0300 refers to it
> without a hyphen[1]. Thus I cannot find out of the point of rewording...
> 
> > Loongson 2K0300 is a multi-function SoC build upon the LA264 processor
> > core, ...
> 
> I'll appreciate and adapt it if you could explain why the change is
> necessary. Thanks for your patience.

Though I still don't understand purpose of the change, I've sent v3[2]
with naming style adjusted and all comments you left in PATCH 2
resolved. Thanks for your review.

> Best regards,
> Yao Zi
> 
> [1]: https://loongson.cn/EN/product/show?id=35

Regards,
Yao Zi

[2]: https://lore.kernel.org/linux-gpio/20250904013438.2405-1-ziyao@disroot.org/