From: Dan Carpenter <dan.carpenter@linaro.org>
To: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/16] staging: rtl8723bs: fix excessive indentation in nested if statement
Date: Thu, 4 Sep 2025 11:04:34 +0300 [thread overview]
Message-ID: <aLlIEspZ2wLRnCru@stanley.mountain> (raw)
In-Reply-To: <20250904021448.216461-10-vivek.balachandhar@gmail.com>
On Thu, Sep 04, 2025 at 02:14:41AM +0000, Vivek BalachandharTN wrote:
> Adjust indentation in a nested if-statement to match kernel coding
> style and improve readability.
>
> No functional changes.
>
> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index d05ff073af2d..a2b1e34765ac 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -1254,8 +1254,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf)
>
> ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->network.mac_address);
> if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == true) {
> - if (ptarget_wlan)
> - ptarget_wlan->fixed = true;
> + if (ptarget_wlan)
> + ptarget_wlan->fixed = true;
Wait, what? We're moving from tabs to 4 space indents?
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-04 8:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 2:14 [PATCH v2 00/16] rtl8723bs: cleanup and style improvements for better readability Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 01/16] staging: rtl8723bs: fix spacing around operators Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 02/16] staging: rtl8723bs: remove unnecessary space after type cast Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 03/16] staging: rtl8723bs: fix overlong lines to conform with kernel coding style Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 04/16] staging: rtl8723bs: align asterisk in block comment to fix formatting Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 05/16] staging: rtl8723bs: fix logical continuation style by moving to previous line Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 06/16] staging: rtl8723bs: fix indentation to align with open parenthesis Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 07/16] staging: rtl8723bs: adding asterisks in multi-line block comments Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 08/16] staging: rtl8723bs: remove space before semicolon Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 09/16] staging: rtl8723bs: fix excessive indentation in nested if statement Vivek BalachandharTN
2025-09-04 8:04 ` Dan Carpenter [this message]
2025-09-05 6:31 ` Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 10/16] staging: rtl8723bs: fix unbalanced braces around conditional blocks Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 11/16] staging: rtl8723bs: remove unnecessary parentheses in conditional Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 12/16] staging: rtl8723bs: remove unnecessary braces for single statement blocks Vivek BalachandharTN
2025-09-04 7:42 ` Dan Carpenter
2025-09-05 6:25 ` Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 13/16] staging: rtl8723bs: add braces to all arms of conditional statement Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 14/16] staging: rtl8723bs: fix line ending with '(' Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 15/16] staging: rtl8723bs: place constant on right side of comparison Vivek BalachandharTN
2025-09-04 2:14 ` [PATCH v2 16/16] staging: rtl8723bs: merge nested if conditions for clarity and tab problems Vivek BalachandharTN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLlIEspZ2wLRnCru@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vivek.balachandhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.