From: Peilin Ye <yepeilin@google.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Josh Don <joshdon@google.com>, Barret Rhoden <brho@google.com>
Subject: Re: [PATCH bpf] bpf/helpers: Skip memcg accounting in __bpf_async_init()
Date: Fri, 5 Sep 2025 06:28:55 +0000 [thread overview]
Message-ID: <aLqDJ0v-pG855N4p@google.com> (raw)
In-Reply-To: <20250905061919.439648-1-yepeilin@google.com>
Hi all,
On Fri, Sep 05, 2025 at 06:19:17AM +0000, Peilin Ye wrote:
> The above was reproduced on bpf-next (b338cf849ec8) by modifying
> ./tools/sched_ext/scx_flatcg.bpf.c to call bpf_timer_init() during
> ops.runnable(), and hacking [1] the memcg accounting code a bit to make
> it (much more likely to) raise an MEMCG_MAX event from a
> bpf_timer_init() call.
FWIW, below are changes I made to scx_flatcg.bpf.c to reproduce the
hardlockup. Please let me know if there's more info that I can provide.
Thanks,
Peilin Ye
--- a/tools/sched_ext/scx_flatcg.bpf.c
+++ b/tools/sched_ext/scx_flatcg.bpf.c
@@ -504,8 +504,31 @@ static void update_active_weight_sums(struct cgroup *cgrp, bool runnable)
cgrp_refresh_hweight(cgrp, cgc);
}
+struct __bpf_timer {
+ struct bpf_timer timer;
+};
+#define NUM_BPF_TIMERS 10
+struct {
+ __uint(type, BPF_MAP_TYPE_ARRAY);
+ __uint(max_entries, NUM_BPF_TIMERS);
+ __type(key, u32);
+ __type(value, struct __bpf_timer);
+} timer_map SEC(".maps");
+int count = 0;
+
void BPF_STRUCT_OPS(fcg_runnable, struct task_struct *p, u64 enq_flags)
{
+ if (count < NUM_BPF_TIMERS) {
+ struct bpf_timer *timer;
+ u32 key = count;
+
+ timer = bpf_map_lookup_elem(&timer_map, &key);
+ if (!timer)
+ return;
+ bpf_timer_init(timer, &timer_map, CLOCK_MONOTONIC);
+ count++;
+ }
+
struct cgroup *cgrp;
cgrp = __COMPAT_scx_bpf_task_cgroup(p);
next prev parent reply other threads:[~2025-09-05 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 6:19 [PATCH bpf] bpf/helpers: Skip memcg accounting in __bpf_async_init() Peilin Ye
2025-09-05 6:28 ` Peilin Ye [this message]
2025-09-05 15:18 ` Alexei Starovoitov
2025-09-05 17:31 ` Shakeel Butt
2025-09-05 18:23 ` Peilin Ye
2025-09-05 19:14 ` Peilin Ye
2025-09-05 20:32 ` Shakeel Butt
2025-09-05 19:48 ` Shakeel Butt
2025-09-05 20:31 ` Peilin Ye
2025-09-05 23:51 ` Peilin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLqDJ0v-pG855N4p@google.com \
--to=yepeilin@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brho@google.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=joshdon@google.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.