All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Oberfichtner <pro@denx.de>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	u-boot@lists.denx.de, Andre Przywara <andre.przywara@arm.com>,
	Anshul Dalal <anshuld@ti.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Greg Malysa <malysagreg@gmail.com>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Jerome Forissier <jerome.forissier@linaro.org>,
	Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
	Peng Fan <peng.fan@nxp.com>, Simon Glass <sjg@chromium.org>,
	Tom Rini <trini@konsulko.com>,
	Trevor Woerner <twoerner@gmail.com>, Ye Li <ye.li@nxp.com>
Subject: Re: [PATCH v3 5/5] Image size checks: Simplify SPL_SIZE_LIMIT logic
Date: Fri, 5 Sep 2025 10:19:48 +0200	[thread overview]
Message-ID: <aLqdJLy-FsgZD4H2@aristophanes> (raw)
In-Reply-To: <1c505e20-74e4-4525-bba9-1f1d74ce6b6f@mailbox.org>

On Thu, Sep 04, 2025 at 05:02:30PM +0200, Marek Vasut wrote:
> On 9/4/25 10:23 AM, Philip Oberfichtner wrote:
> > On Wed, Sep 03, 2025 at 02:59:01PM +0200, Marek Vasut wrote:
> > > On 9/3/25 12:56 PM, Philip Oberfichtner wrote:
> > > > Simplify the depends-on logic for SPL_SIZE_LIMIT. No functional change.
> > > > 
> > > > Signed-off-by: Philip Oberfichtner <pro@denx.de>
> > > > ---
> > > >    Kconfig | 2 +-
> > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/Kconfig b/Kconfig
> > > > index aa00669ba20..343299eed50 100644
> > > > --- a/Kconfig
> > > > +++ b/Kconfig
> > > > @@ -588,8 +588,8 @@ config HAS_SPL_SIZE_LIMIT
> > > >    config SPL_SIZE_LIMIT
> > > >    	hex "Maximum size of SPL image in bytes"
> > > >    	depends on HAS_SPL_SIZE_LIMIT
> > > > -	default 0x11000 if ARCH_MX6 && !MX6_OCRAM_256KB
> > > >    	default 0x31000 if ARCH_MX6 && MX6_OCRAM_256KB
> > > > +	default 0x11000 if ARCH_MX6
> > > This makes it less obvious what the other case (!256 kiB SRAM SoCs) covers,
> > > why is that an improvement ?
> > 
> > This was originally Heinrich's idea. I personally find it better this
> > way, but I won't argue about it.
> 
> Why do you send a patch which you cannot even argue is correct ?
> 
> > Can you please find a consensus the two of you?
> 
> No, you should be able to clarify why this patch should be applied, do not
> shift this onus to other participants.

I prefer conciseness over verbosity. That's all. But I'm okay to step
back on this one. There may be different view points.

      reply	other threads:[~2025-09-05  8:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 10:56 [PATCH v3 0/5] Simplify image size checks Philip Oberfichtner
2025-09-03 10:56 ` [PATCH v3 1/5] Image size checks: Move all configs in one place Philip Oberfichtner
2025-09-03 12:50   ` Marek Vasut
2025-09-04  8:12     ` Philip Oberfichtner
2025-09-04 13:54       ` Marek Vasut
2025-09-05  8:13         ` Philip Oberfichtner
2025-09-05 14:22           ` Tom Rini
2025-10-10 14:19             ` Philip Oberfichtner
2025-09-03 10:56 ` [PATCH v3 2/5] Image size checks: Use HAS_SIZE_LIMIT consistently Philip Oberfichtner
2025-09-03 12:51   ` Marek Vasut
2025-09-04  8:19     ` Philip Oberfichtner
2025-09-04 13:56       ` Marek Vasut
2025-09-05  8:15         ` Philip Oberfichtner
2025-09-05 14:19   ` Tom Rini
2025-09-30  8:33     ` Philip Oberfichtner
2025-09-30 14:45       ` Tom Rini
2025-10-02  8:55         ` Philip Oberfichtner
2025-10-02 21:19           ` Tom Rini
2025-10-10 14:28             ` Philip Oberfichtner
2025-09-03 10:56 ` [PATCH v3 3/5] Image size checks: Use consistent help texts Philip Oberfichtner
2025-09-03 12:54   ` Marek Vasut
2025-09-04  8:20     ` Philip Oberfichtner
2025-09-03 10:56 ` [PATCH v3 4/5] Image size checks: Deduplicate Makefile Philip Oberfichtner
2025-09-03 13:02   ` Marek Vasut
2025-09-04  8:30     ` Philip Oberfichtner
2025-09-04 15:03       ` Marek Vasut
2025-09-05  8:22         ` Philip Oberfichtner
2025-09-03 10:56 ` [PATCH v3 5/5] Image size checks: Simplify SPL_SIZE_LIMIT logic Philip Oberfichtner
2025-09-03 12:08   ` Heinrich Schuchardt
2025-09-03 12:59   ` Marek Vasut
2025-09-04  8:23     ` Philip Oberfichtner
2025-09-04  8:30       ` Heinrich Schuchardt
2025-09-04 15:02       ` Marek Vasut
2025-09-05  8:19         ` Philip Oberfichtner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLqdJLy-FsgZD4H2@aristophanes \
    --to=pro@denx.de \
    --cc=andre.przywara@arm.com \
    --cc=anshuld@ti.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=malysagreg@gmail.com \
    --cc=marek.vasut@mailbox.org \
    --cc=nathan.morrison@timesys.com \
    --cc=peng.fan@nxp.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=twoerner@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.