From: Andrea della Porta <andrea.porta@suse.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, iivanov@suse.de, svarbanov@suse.de,
mbrugger@suse.com, Jonathan Bell <jonathan@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 1/2] arm64: dts: broadcom: rp1: Add USB nodes
Date: Fri, 5 Sep 2025 10:46:08 +0200 [thread overview]
Message-ID: <aLqjUNAdremFoM-F@apocalypse> (raw)
In-Reply-To: <f7bb0739-3161-4d70-87e5-8c978a023361@kernel.org>
Hi Krzysztof,
On 13:05 Thu 04 Sep , Krzysztof Kozlowski wrote:
> On 28/08/2025 15:50, Andrea della Porta wrote:
> > The RaspberryPi 5 has RP1 chipset containing two USB host controller,
> > while presenting two USB 2.0 and two USB 3.0 ports to the outside.
> >
> > Add the relevant USB nodes to the devicetree.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > arch/arm64/boot/dts/broadcom/rp1-common.dtsi | 28 ++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/rp1-common.dtsi b/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > index 5002a375eb0b..116617fcb1eb 100644
> > --- a/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > +++ b/arch/arm64/boot/dts/broadcom/rp1-common.dtsi
> > @@ -39,4 +39,32 @@ rp1_gpio: pinctrl@400d0000 {
> > <1 IRQ_TYPE_LEVEL_HIGH>,
> > <2 IRQ_TYPE_LEVEL_HIGH>;
> > };
> > +
> > + rp1_usb0: usb@40200000 {
> > + reg = <0x00 0x40200000 0x0 0x100000>;
> > + compatible = "snps,dwc3";
> Please order properties and nodes according to DTS coding style.
I'll do.
Many thanks,
Andrea
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2025-09-05 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 13:50 [PATCH 1/2] arm64: dts: broadcom: rp1: Add USB nodes Andrea della Porta
2025-08-28 13:50 ` [PATCH 2/2] arm64: dts: broadcom: Enable USB devicetree entries for Rpi5 Andrea della Porta
2025-09-04 10:46 ` [PATCH 1/2] arm64: dts: broadcom: rp1: Add USB nodes Stanimir Varbanov
2025-09-05 8:45 ` Andrea della Porta
2025-09-04 11:05 ` Krzysztof Kozlowski
2025-09-05 8:46 ` Andrea della Porta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLqjUNAdremFoM-F@apocalypse \
--to=andrea.porta@suse.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=iivanov@suse.de \
--cc=jonathan@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.com \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=svarbanov@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.