Re: [PATCH v1 1/1] nvme-core: exclude ioccsz/iorcsz checks for admin ctrlr

[Kamaljit Singh <kamaljit.singh@opensource.wdc.com>]

On Fri, Sep 05, 2025 at 03:49:23PM -0600, Keith Busch wrote:
> On Fri, Sep 05, 2025 at 02:10:01PM -0700, Kamaljit Singh wrote:
> > An administrative controller does not support I/O queues, hence it
> > should exclude existing checks for IOCCSZ/IORCSZ.
> > 
> > -	if (!nvme_discovery_ctrl(ctrl) && ctrl->iorcsz < 1) {
> > +	if (!nvmf_discovery_ctrl(ctrl) && !nvme_admin_ctrl(ctrl) && ctrl->iorcsz < 1) {
> 
> Excessive line length over 80 chars.
> 
> Perhaps, though, we should have a helper to indicate IO controllers
> rather than chaining conditions for everything that isn't one.
Sure, I'll add a new function nvme_is_io_controller() and make it dependent 
on nvmf_discovery_ctrl() and nvme_admin_ctrl(). How does that sound?

Thanks,
Kamaljit