From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4082DCA0FED for ; Fri, 5 Sep 2025 23:34:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1112821.1460982 (Exim 4.92) (envelope-from ) id 1uufwV-00030V-Rh; Fri, 05 Sep 2025 23:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1112821.1460982; Fri, 05 Sep 2025 23:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uufwV-00030O-PA; Fri, 05 Sep 2025 23:34:07 +0000 Received: by outflank-mailman (input) for mailman id 1112821; Fri, 05 Sep 2025 23:34:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uufwU-00030I-DU for xen-devel@lists.xenproject.org; Fri, 05 Sep 2025 23:34:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uufwS-008ANg-2G; Fri, 05 Sep 2025 23:34:04 +0000 Received: from [19.12.91.86] (helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uufwS-0005QN-22; Fri, 05 Sep 2025 23:34:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:Date:From; bh=fE7dfamD3/y6Do8P8KllY6vbBuhY9YcldmKhoAUq324=; b= ozGLzVylFoCz98McC8cnuTlnSVXrPs7Mrsdilm3NwQM/G18moXeHzuYG7YMYz4jT0K3orJtVOjb+z Yz7o2DUF1DzsJRomFvAWq0R5wK+9sGmP89irMyW9JC9jeOj/VW/w9E3j2Gdx+GaP2C8wxUROoDxz6 FGUvPW1ZmgY8z+XLs=; From: dmukhin@xen.org Date: Fri, 5 Sep 2025 16:34:03 -0700 To: Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, dmukhin@ford.com Subject: Re: [PATCH v5 03/15] emul/ns16x50: implement emulator stub Message-ID: References: <20250828235409.2835815-1-dmukhin@ford.com> <20250828235409.2835815-4-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 02, 2025 at 11:36:19AM +0200, Jan Beulich wrote: > On 29.08.2025 21:57, Stefano Stabellini wrote: > > On Thu, 28 Aug 2025, dmukhin@xen.org wrote: > >> +static void cf_check ns16x50_free(void *arg) > >> +{ > >> + struct vuart_ns16x50 *vdev = arg; > >> + > >> + if ( vdev ) > >> + ns16x50_deinit(vdev); > >> + > >> + XVFREE(vdev); > > > > XVFREE should only be called if ( vdev ) > > Why would this be? Like free(), both xfree() and xvfree() are fine to be > called with a NULL pointer. What's odd here is that the uppercase form (the > wrapper macro) is used - clearing the local variable is pointless when it > is about to go out of scope anyway. Thank you for remark! I switched the code to xvfree() in v6